From: "Érico Nogueira" <ericonr@disroot.org>
To: "Frank Ch. Eigler" <fche@redhat.com>, "Mark Wielaard" <mark@klomp.org>
Cc: "Érico Nogueira" <ericonr@disroot.org>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] Don't use locale functions when libintl header isn't included.
Date: Mon, 26 Oct 2020 19:44:43 -0300 [thread overview]
Message-ID: <C6N6QJXBKD6U.WRRRQJPSQGVW@mussels> (raw)
In-Reply-To: <20201026222257.GB23993@redhat.com>
On Mon Oct 26, 2020 at 3:22 PM -03, Frank Ch. Eigler wrote:
> Hi -
>
> > On Mon, 2020-10-26 at 01:11 -0300, Érico Nogueira via Elfutils-devel wrote:
> > > debuginfod.cxx used the bindtextdomain() and textdomain() functions
> > > despite not including any translated output. These functions were also
> > > used without including the libintl.h header.
> >
> > debuginfod doesn't directly use any translated output, but it links
> > against libeu.a which provides the print_version function, which does
> > use translated output. So maybe the correct fix is to #include
> > <libintl.h> instead?
>
> I think their concern may be that they don't have any libintl.h or
> related functions in the musl world.
>
> - FChE
No, musl does provide a libintl.h header and the necessary
implementations. My changes to debuginfod.cxx were only necessary
because the file was using functions from libintl.h even though the
header itself wasn't included. Following your comment on IRC, I will
make a new patch that just includes libintl.h.
Cheers,
Érico
prev parent reply other threads:[~2020-10-26 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 4:11 Érico Nogueira
2020-10-26 18:46 ` Mark Wielaard
2020-10-26 18:53 ` Érico Nogueira
2020-10-26 22:22 ` Mark Wielaard
2020-10-26 22:22 ` Frank Ch. Eigler
2020-10-26 22:44 ` Érico Nogueira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6N6QJXBKD6U.WRRRQJPSQGVW@mussels \
--to=ericonr@disroot.org \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).