From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) by sourceware.org (Postfix) with ESMTPS id D4DBC3948A91 for ; Mon, 26 Oct 2020 22:49:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D4DBC3948A91 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id DD20C535A3; Mon, 26 Oct 2020 23:49:08 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XrreXQWvVPoc; Mon, 26 Oct 2020 23:49:07 +0100 (CET) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Cc: =?utf-8?q?=C3=89rico_Nogueira?= , Subject: Re: [PATCH] Don't use locale functions when libintl header isn't included. From: =?utf-8?q?=C3=89rico_Nogueira?= To: "Frank Ch. Eigler" , "Mark Wielaard" Date: Mon, 26 Oct 2020 19:44:43 -0300 Message-Id: In-Reply-To: <20201026222257.GB23993@redhat.com> X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 22:49:12 -0000 On Mon Oct 26, 2020 at 3:22 PM -03, Frank Ch. Eigler wrote: > Hi - > > > On Mon, 2020-10-26 at 01:11 -0300, =C3=83=C2=89rico Nogueira via Elfuti= ls-devel wrote: > > > debuginfod.cxx used the bindtextdomain() and textdomain() functions > > > despite not including any translated output. These functions were als= o > > > used without including the libintl.h header. > >=20 > > debuginfod doesn't directly use any translated output, but it links > > against libeu.a which provides the print_version function, which does > > use translated output. So maybe the correct fix is to #include > > instead? > > I think their concern may be that they don't have any libintl.h or > related functions in the musl world. > > - FChE No, musl does provide a libintl.h header and the necessary implementations. My changes to debuginfod.cxx were only necessary because the file was using functions from libintl.h even though the header itself wasn't included. Following your comment on IRC, I will make a new patch that just includes libintl.h. Cheers, =C3=89rico