* [PATCH] libcpu: linking i386_gendis requires obstack.
@ 2020-12-16 18:56 Érico Nogueira
2020-12-16 21:48 ` Mark Wielaard
0 siblings, 1 reply; 3+ messages in thread
From: Érico Nogueira @ 2020-12-16 18:56 UTC (permalink / raw)
To: elfutils-devel; +Cc: Érico Rolim
From: Érico Rolim <erico.erc@gmail.com>
---
Noticed while building from master today.
libcpu/ChangeLog | 4 ++++
libcpu/Makefile.am | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/libcpu/ChangeLog b/libcpu/ChangeLog
index 781c8f41..af7ea96c 100644
--- a/libcpu/ChangeLog
+++ b/libcpu/ChangeLog
@@ -1,3 +1,7 @@
+2020-12-16 Érico Nogueira <ericonr@disroot.org>
+
+ * Makefile.am (i386_gendis_LDADD): Add obstack_LIBS.
+
2020-12-16 Dmitry V. Levin <ldv@altlinux.org>
* i386_lex.l (invalid_char): Replace gettext(...) with _(...).
diff --git a/libcpu/Makefile.am b/libcpu/Makefile.am
index 59def7d1..43844ecf 100644
--- a/libcpu/Makefile.am
+++ b/libcpu/Makefile.am
@@ -86,7 +86,7 @@ i386_lex_CFLAGS = -Wno-unused-label -Wno-unused-function -Wno-sign-compare \
i386_parse.o: i386_parse.c i386.mnemonics
i386_parse_CFLAGS = -DNMNES="`wc -l < i386.mnemonics`"
i386_lex.o: i386_parse.h
-i386_gendis_LDADD = $(libeu) -lm
+i386_gendis_LDADD = $(libeu) -lm $(obstack_LIBS)
i386_parse.h: i386_parse.c ;
--
2.29.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libcpu: linking i386_gendis requires obstack.
2020-12-16 18:56 [PATCH] libcpu: linking i386_gendis requires obstack Érico Nogueira
@ 2020-12-16 21:48 ` Mark Wielaard
2020-12-16 22:12 ` Érico Nogueira
0 siblings, 1 reply; 3+ messages in thread
From: Mark Wielaard @ 2020-12-16 21:48 UTC (permalink / raw)
To: Érico Nogueira; +Cc: elfutils-devel, Érico Rolim
On Wed, Dec 16, 2020 at 03:56:14PM -0300, Érico Nogueira via Elfutils-devel wrote:
> Noticed while building from master today.
Yes, you are right. i386_parse.y uses obstacks. Thanks for the
ChangeLog entry. Next time please do use a Signed-off-by line. See
CONTRIBUTING.
Pushed,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libcpu: linking i386_gendis requires obstack.
2020-12-16 21:48 ` Mark Wielaard
@ 2020-12-16 22:12 ` Érico Nogueira
0 siblings, 0 replies; 3+ messages in thread
From: Érico Nogueira @ 2020-12-16 22:12 UTC (permalink / raw)
To: Mark Wielaard; +Cc: elfutils-devel, Érico Rolim
On Wed Dec 16, 2020 at 6:48 PM -03, Mark Wielaard wrote:
> On Wed, Dec 16, 2020 at 03:56:14PM -0300, Érico Nogueira via
> Elfutils-devel wrote:
> > Noticed while building from master today.
>
> Yes, you are right. i386_parse.y uses obstacks. Thanks for the
> ChangeLog entry. Next time please do use a Signed-off-by line. See
> CONTRIBUTING.
I completely forgot about the Signed-off-by part, sorry! Will re-send
my other patches with it.
>
> Pushed,
>
> Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-16 22:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 18:56 [PATCH] libcpu: linking i386_gendis requires obstack Érico Nogueira
2020-12-16 21:48 ` Mark Wielaard
2020-12-16 22:12 ` Érico Nogueira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).