From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by sourceware.org (Postfix) with ESMTPS id B2D543858425 for ; Tue, 20 Dec 2022 16:31:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2D543858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x934.google.com with SMTP id m5so2980795uah.3 for ; Tue, 20 Dec 2022 08:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=X7OkSs950MBbf0LJwC3qsycoxl7yM/yTOR2zHrtEBKI=; b=FENxH6ch4Vp9DtIiQUC8TM3CZXkh6ZQCgYdLqh1O9AhEvVM+xKXIw7F14maYum28/V CtBgaCcUx4ufr42bxebZwCrFELovWmqqxr9jLlTwhw/KKV/PitYR2T2OBtmF/L8+Q+95 kPtW2c03c+9FgF0EZLKU8kfa3ivFBHudIvFNGXayM/5qXGonJyKLEK9DL4VgVycbMR7U +HaTs0UMPiHZrH+HjdVEgjfnIvUBHdU13mfDy0izUCZCFOymnJWacmGDrcrVEsKqgW8i pJD20CVyVOWT8524fV7J+Kq9nqi94Q+C4TKCnjOJAGCyDCrd07xmVLyZx4IreAKigxnY NQ/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X7OkSs950MBbf0LJwC3qsycoxl7yM/yTOR2zHrtEBKI=; b=x0hQaOuBTCMTZWVcffepAEdzqa8OR+JmjEOmXuDfqcBLs5Mb+CJ7xYWSNOYKIf7uxD wB2CfaW3VNucRVlfkecaZDJfBaLOQbI5xnsNzAgBwZbITLWIDvK2fe8B4FZX94/ScS5t 9Ec+au32uzizP0NqhTUGsVoIln5k1+ZVLkVuwfxMFoG4IkStpyC6C77QZbzMvT3you0F IXjdnssT8/179aDSBWzviK+VoaQ1uZzeFIbPoStL7QZsKHXpw1ptH2ONXcJmxF+2c3mz GpAonXeuyFMpRQjPp9z2O6nYdBUnnK7+2I6DVA5CBQ8XjE6Z//tMSPzOV0ux2fpFmJcS G11Q== X-Gm-Message-State: ANoB5pn1ym8ep7x7Agi4x74n4AB3Dy1Q/xDsuoIeqsb4yg+K9PjlXxLO WDHqOTHsSDW3w+Wuhzf3aNSre1/E3yPhwL/BdOKq/yXE50k= X-Google-Smtp-Source: AA0mqf7+/isAC4FiMV7J6TTbpwDKz9OWma5YCpQQFcQU3rsv0jJpmyoh7wpcv4C8AfUet1bDpBjUXAuNZhxMAzfB7WY= X-Received: by 2002:ab0:7286:0:b0:418:455f:2e94 with SMTP id w6-20020ab07286000000b00418455f2e94mr48047162uao.75.1671553908044; Tue, 20 Dec 2022 08:31:48 -0800 (PST) MIME-Version: 1.0 References: <20221020182603.815-1-luoyonggang@gmail.com> <20221020182603.815-15-luoyonggang@gmail.com> <1b9d9b01e459753b5b428f4a9d8113a47801f212.camel@klomp.org> <0bc05adaf492c5f57b0b45f520be14b78f3fbd53.camel@klomp.org> In-Reply-To: <0bc05adaf492c5f57b0b45f520be14b78f3fbd53.camel@klomp.org> Reply-To: luoyonggang@gmail.com From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Wed, 21 Dec 2022 00:31:35 +0800 Message-ID: Subject: Re: [PATCH 14/25] libdw: check __OPTIMIZE__ in dwarf_whatattr.c and dwarf_whatform.c to match the header To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: multipart/alternative; boundary="000000000000e979e905f044f85c" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000e979e905f044f85c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 20, 2022 at 11:08 PM Mark Wielaard wrote: > > On Sat, 2022-12-17 at 05:47 +0800, =E7=BD=97=E5=8B=87=E5=88=9A(Yonggang L= uo) wrote: > > From bdf8a3b45f063d010e7c93b3d3bfc42b801ee9b2 Mon Sep 17 00:00:00 > > 2001 > > From: Yonggang Luo > > Date: Thu, 20 Oct 2022 02:50:03 +0800 > > Subject: [PATCH] libdw: Fixes compile of dwarf_whatattr.c and > > dwarf_whatform.c > > > > If __OPTIMIZE__ is defined, then compile dwarf_whatattr.c and > > dwarf_whatform.c > > will cause symbol conflict between > > dwarf_whatattr.c and libdw.h, > > dwarf_whatform.c and libdw.h, > > > > So always undefined __OPTIMIZE__ when compiling these two files > > I don't think this is correct either. Some system headers might depend > on __OPTIMIZE__ being defined. Are you using a compiler that doesn't > define __OPTIMIZE__ ? In debug mode, __OPTIMIZE__ won't be defined. > > Cheers, > > Mark -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --000000000000e979e905f044f85c--