From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by sourceware.org (Postfix) with ESMTPS id 4EF3F3858D28 for ; Mon, 19 Dec 2022 12:33:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EF3F3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2c.google.com with SMTP id i2so8525350vsc.1 for ; Mon, 19 Dec 2022 04:33:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PySE/KYzvDtCnMBQ6Lxl7uIRhKc7Qo6ifGi0r6Cz7dE=; b=gnZbA4R6aoNwIAQtSCOt94aHXDcKFQUiWqraAjZttn/FOYenxgx5CS8ITogPF4OgYf Js1OKSdyg42QPeRhJFsBs7+vHlbxfXGz6d80vo/RSclXxFUk+9NIlbtljmRAGKpYFG6f Ug1kBOPsm061hfmOeuGG5RFkfe81uRvnT+QEpv9O1PVYlFOWeTe+zlTfGrUkDkqcLB1b s01ogNNokpgxL4nHUwCgEfNuYGcE8l9Yxg/J9xkKvjHDWHKv8BKkJwnnnXrDiIStPaNN jr8cFKkeUXA7I2i19Hkh5W7dWyeBhSq38hZqORffCfS3yhoqb6pNIVgq/eUl0PBo65NI xtrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PySE/KYzvDtCnMBQ6Lxl7uIRhKc7Qo6ifGi0r6Cz7dE=; b=XmlT566wJgthcRcreslKFuTetlMbqZ0TNkSaGugI5uj+IouI6zz+CrTW7LLVAEqOeC ixeLcHAmGajx2vjzgYlYFTWgSojjMJIZa4XRtLtOxiasEEcgXvyKhDgY5TpwvFcmRVbJ zXstfDag7u6yaZeEuq+aCKCZOXKKjMS17iUvdnIx/kXCSPq+KFs2qIi4ZcZDO0HFkS25 IP0wlBlqGKwjjZy0QiJXFTug4bCWUmUZJje6aG3H/+v2xMWX1dKkWf/cPSUrJV2vwszF UfMtNL7jjAzmgtMzEt9vW8+GRV7sqG4DO3XWbyrzPhWEir0rHH6p2zL2N7tnG9W2bg0Q o1UQ== X-Gm-Message-State: ANoB5pkAbQ+7/RPtY+WiwLjjzqj5F2Nhb/Y2sqW8QcikbAi2E2tGa1zq lnVpyarKC0+lXNzP+RwxIskTXqLfpc+jBflX5jfY7NwpTVk= X-Google-Smtp-Source: AA0mqf5DcxoOI5oz2yzG5LdYS/Pm0ldp/dbGSDTlSSc0ptZFqv6zAA9MOB05+C+BRbfv41Tlqi8TPMayO/OoIgFVYWw= X-Received: by 2002:a05:6102:36f:b0:3b2:f281:83b8 with SMTP id f15-20020a056102036f00b003b2f28183b8mr10241385vsa.7.1671453181169; Mon, 19 Dec 2022 04:33:01 -0800 (PST) MIME-Version: 1.0 References: <20221217165213.152-1-luoyonggang@gmail.com> <20221217165213.152-14-luoyonggang@gmail.com> In-Reply-To: <20221217165213.152-14-luoyonggang@gmail.com> Reply-To: luoyonggang@gmail.com From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Mon, 19 Dec 2022 20:32:48 +0800 Message-ID: Subject: Re: [PATCH v2 13/16] lib: isatty is not available on windows To: elfutils-devel@sourceware.org Content-Type: multipart/alternative; boundary="0000000000001f556005f02d85b8" X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001f556005f02d85b8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It's because lack STDOUT_FILENO, so this patch can be dropped On Sun, Dec 18, 2022 at 12:52 AM Yonggang Luo wrote: > > Signed-off-by: Yonggang Luo > --- > lib/color.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/color.c b/lib/color.c > index 8063dc26..963a2ec2 100644 > --- a/lib/color.c > +++ b/lib/color.c > @@ -117,9 +117,14 @@ parse_opt (int key, char *arg, > if (strcmp (arg, values[i].str) =3D=3D 0) > { > color_mode =3D values[i].mode; > +#ifdef _WIN32 > + if (color_mode =3D=3D color_auto) > + color_mode =3D color_never; > +#else > if (color_mode =3D=3D color_auto) > color_mode > =3D isatty (STDOUT_FILENO) ? color_always : color_nev= er; > +#endif > break; > } > if (i =3D=3D nvalues) > -- > 2.36.1.windows.1 > -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --0000000000001f556005f02d85b8--