From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by sourceware.org (Postfix) with ESMTPS id DE08B3858D1E for ; Sat, 15 Oct 2022 17:01:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE08B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe29.google.com with SMTP id 1so3543409vsx.1 for ; Sat, 15 Oct 2022 10:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Uf9gl9Fr5Zk8DoKm6FDFI9ex53H9eu7qM0TjEij1+jI=; b=qy5Rzk9CVsjCRoMRP3mPjH47zDlL9aMUqAMXp3JpkEAw3a5NVEFvQZAU+hckWli+Pl j6KG7vqLvNIK0dvoEvhjzqEegm272ipKxR4tfMUw9IWDm2OP2b9vlajvCnkDKvDCmze/ 2f7cTA+FxIqR1IKA6x9wLMZ3mRzx+P04OsUYHHaxw5WduJuqOgmZuU8+iPdlAE+E9Y/a 0Uo62JoRByPlwipgSYJER6/KdlMrVoeV9CLNdVD6ytTF/N9Q1tZo/5DFu4B4ajG4TnPz AfkJu9ahqf9xTIWaXxUSXE++MEpZU76E8uB7W2zcWt1CNJSZeMpAbd+M7N4LAruOH4BV 5o2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uf9gl9Fr5Zk8DoKm6FDFI9ex53H9eu7qM0TjEij1+jI=; b=Q8la+jfAtBdnbFhfyo58MMdclFwnHtKEGFIO6oL2tA+waG86u4X8heHswyNIcANQqp dR7iXNhgnAM7A6X8Y+fOHqLjyndEvzwbfgwn+3RTQa7qADiOPBd46/sD0JAA8/jlnMld LD9UVqHaNowCrcWRId72RtPdlNjsoE+f0S/tApxwohEkDU5nZ8pFFLJD7/ewctMKX1P0 EgtR2KDcwSgf3DIGmhMU0v50swuM2cIifV5XN9CiRmeiq/PcwzyJowvMoSPpwlLYWRe1 RDAno1YNV3ldoojBmKoKQ8icG4o3cV5jM8kJBYEua78wGkBh+7NX5vBqHfgajO9u3JSw zfyg== X-Gm-Message-State: ACrzQf04JKbu6hdMIUBJ6DvxWXkMrsFM2ABjecYYCP3VtiE/AqitD1fV VO2HenII4ojlw79h6lO4l17aFlJuroLZzMXMiz1QLjEXbnU= X-Google-Smtp-Source: AMsMyM4vVZHNPBOkB29QsJcYyG0C08qh4nuUhKHshEznRZ3vktE55XKrHeh8YO9EUOknJs259VrLls+yTkpeFW+phAE= X-Received: by 2002:a67:d39c:0:b0:3a7:6b54:44d9 with SMTP id b28-20020a67d39c000000b003a76b5444d9mr1227405vsj.7.1665853301223; Sat, 15 Oct 2022 10:01:41 -0700 (PDT) MIME-Version: 1.0 References: <20220920084307.1696-1-luoyonggang@gmail.com> <20220920084307.1696-3-luoyonggang@gmail.com> In-Reply-To: Reply-To: luoyonggang@gmail.com From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Sun, 16 Oct 2022 01:01:29 +0800 Message-ID: Subject: Re: [PATCH 2/7] move platform depended include into system.h To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: multipart/alternative; boundary="00000000000044799205eb15b25f" X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000044799205eb15b25f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable OK, updated in v2 On Sat, Oct 15, 2022 at 5:16 AM Mark Wielaard wrote: > > On Tue, Sep 20, 2022 at 04:43:02PM +0800, Yonggang Luo via Elfutils-devel wrote: > > All of these files either #include directly or #include "libelfP.h" > > And now "libelfP.h also #include , so the platform depended include > > can be moved to system.h safely > > I like this in theory since it cleans up some of the includes. > But it doesn't work as is. > > libebl/eblobjnotetypename.c only included system.h so now doesn't > compile anymore. And libintl.h is removed from libelf/elf_error.c > which really is necessary. > > Cheers, > > Mark -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --00000000000044799205eb15b25f--