From: "罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec'
Date: Thu, 20 Oct 2022 02:45:57 +0800 [thread overview]
Message-ID: <CAE2XoE-xfFQNMN1JYSi8Kp+-DUUookRkzwUV+OvKGfnZKDXKEA@mail.gmail.com> (raw)
In-Reply-To: <Y0nH98k6YumMRSz0@wildebeest.org>
[-- Attachment #1: Type: text/plain, Size: 2382 bytes --]
I really want this to be merged :) ping Frank,
as this would stop me clone elfutils on windows
On Sat, Oct 15, 2022 at 4:35 AM Mark Wielaard <mark@klomp.org> wrote:
>
> Hi,
>
> On Tue, Sep 20, 2022 at 04:43:01PM +0800, Yonggang Luo via Elfutils-devel
wrote:
> > These filenames are invalid on win32
>
> This looks ok to me, but I don't really know why these files were
> named this way in the first place.
>
> The files themselves are not directly used, they are there to recreate
> the hello3*rpm test files.
>
> Frank, would you mind if these are just renamed to normal *.spec?
>
> Thanks,
>
> Mark
>
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> > ---
> > tests/Makefile.am | 2 +-
> > tests/debuginfod-rpms/{hello2.spec. => hello2.spec} | 0
> > tests/debuginfod-rpms/{hello3.spec. => hello3.spec} | 0
> > 3 files changed, 1 insertion(+), 1 deletion(-)
> > rename tests/debuginfod-rpms/{hello2.spec. => hello2.spec} (100%)
> > rename tests/debuginfod-rpms/{hello3.spec. => hello3.spec} (100%)
> >
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > index 85514898..fc2235f4 100644
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @@ -563,7 +563,7 @@ EXTRA_DIST = run-arextract.sh run-arsymtest.sh
run-ar.sh \
> > debuginfod-rpms/fedora31/hello3-debugsource-1.0-2.x86_64.rpm
\
> > debuginfod-rpms/fedora31/hello3-two-1.0-2.x86_64.rpm \
> >
debuginfod-rpms/fedora31/hello3-two-debuginfo-1.0-2.x86_64.rpm \
> > - debuginfod-rpms/hello2.spec. \
> > + debuginfod-rpms/hello2.spec \
> > debuginfod-rpms/rhel6/hello2-1.0-2.i686.rpm \
> > debuginfod-rpms/rhel6/hello2-1.0-2.src.rpm \
> > debuginfod-rpms/rhel6/hello2-debuginfo-1.0-2.i686.rpm \
> > diff --git a/tests/debuginfod-rpms/hello2.spec.
b/tests/debuginfod-rpms/hello2.spec
> > similarity index 100%
> > rename from tests/debuginfod-rpms/hello2.spec.
> > rename to tests/debuginfod-rpms/hello2.spec
> > diff --git a/tests/debuginfod-rpms/hello3.spec.
b/tests/debuginfod-rpms/hello3.spec
> > similarity index 100%
> > rename from tests/debuginfod-rpms/hello3.spec.
> > rename to tests/debuginfod-rpms/hello3.spec
> > --
> > 2.36.1.windows.1
> >
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
next prev parent reply other threads:[~2022-10-19 18:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 8:43 [PATCH 0/7] Enable building libelf of elfutils on win32 Yonggang Luo
2022-09-20 8:43 ` [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec' Yonggang Luo
2022-10-14 20:35 ` Mark Wielaard
2022-10-19 18:45 ` 罗勇刚(Yonggang Luo) [this message]
2022-10-19 19:49 ` Frank Ch. Eigler
2022-10-19 21:23 ` 罗勇刚(Yonggang Luo)
2022-10-19 21:27 ` 罗勇刚(Yonggang Luo)
2022-10-21 15:45 ` Frank Ch. Eigler
2022-10-20 16:07 ` Mark Wielaard
2022-10-31 13:29 ` Mark Wielaard
2022-11-24 8:27 ` 罗勇刚(Yonggang Luo)
2022-09-20 8:43 ` [PATCH 2/7] move platform depended include into system.h Yonggang Luo
2022-10-14 21:16 ` Mark Wielaard
2022-10-15 17:01 ` 罗勇刚(Yonggang Luo)
2022-09-20 8:43 ` [PATCH 3/7] lib: Use NOT_HAVE_LIBINTL to guard if need #include <libintl.h> Yonggang Luo
2022-09-20 8:43 ` [PATCH 4/7] Remove duplicated " Yonggang Luo
2022-09-20 8:43 ` [PATCH 5/7] Strip __ prefix from __BYTE_ORDER __LITTLE_ENDIAN and __BIG_ENDIAN Yonggang Luo
2022-10-16 21:11 ` Mark Wielaard
2022-10-17 3:40 ` 罗勇刚(Yonggang Luo)
2022-10-17 8:42 ` Mark Wielaard
2022-09-20 8:43 ` [PATCH 6/7] Fixes building with msvc/clang mingw/gcc Yonggang Luo
2022-10-16 21:21 ` Mark Wielaard
2022-12-16 21:12 ` 罗勇刚(Yonggang Luo)
2022-09-20 8:43 ` [PATCH 7/7] Add CMake build files Yonggang Luo
2022-10-16 21:23 ` Mark Wielaard
2022-12-16 21:12 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2XoE-xfFQNMN1JYSi8Kp+-DUUookRkzwUV+OvKGfnZKDXKEA@mail.gmail.com \
--to=luoyonggang@gmail.com \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).