From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by sourceware.org (Postfix) with ESMTPS id 7EDB6384092C for ; Fri, 16 Dec 2022 21:36:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7EDB6384092C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2c.google.com with SMTP id 128so3521096vsz.12 for ; Fri, 16 Dec 2022 13:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3b9U0aGa3WokSV2prF9VsPuyTCjEiFA2F0FFbKoFOIk=; b=JEA3+FfNphHTN6vnA8J32tMvtazttjjaKTzpEuXZu9JWCX1DcHN11iK6MTtDPNvJU5 RnsuM27FOeiWmwu0sngr7uCmeHzVpuosiutvNwRWbdF3A4KYEmhTJ2HxIdS1PcfV4Obh vZd7coXFCoR/j4AJo9D5M3UtGn40zD44iIvIKrLxqjVSMFekkfpFo6SfoCDLqehub8E3 Toyw6QFk4hMtqiA4uoadQ1b2SV0LcwZ/Xh7OYECirkbPCi51InY0o/0XSBnGie9990gZ UiTGzRjYgXjV8R2sVovY/SFMzkX0I/PN/WjfgoFsLjbhjy5U7bSW1cRf0t/MnnwV2Iet Wyhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3b9U0aGa3WokSV2prF9VsPuyTCjEiFA2F0FFbKoFOIk=; b=TsNXPaiRq6Lyc4Dg2yTLU/p1dmM9ctbHV8zbPkddiPUyaH4CuLhPGMO6Abc5BnacGy bdGYhcwVqaLLH+GijqI77VNB6rjo/XlkGbA+VqWSs8S+iiusqbApHZw9s/tx49p616Ni LtHuzsQ+2T8hszpLRIN7eGjtf0VhlEl5P8DOGU4dS98lwa1BDllGgFXa24HTZgDA9ld8 z81ky9h7rAcFuKoZOn/p2qfBnNg0VL5f8KW8Z7+zc+9a9b/O+0L7gi27Xlftqw1RBg7c E1g2aDfqB59pAulPRmT42EwI+BSCsbdTCHxTO/74NEzIABmsIMZgH9gBJbS5EhOHbSDz o13w== X-Gm-Message-State: ANoB5plcOeMNVnhY0tPRLy6ctIwBw6VWJmlsazLun7v6+SomS9Y49Y6r Uiqm2SInkbOy850pX2uq79TMEY1S6mjkLQjSRtE= X-Google-Smtp-Source: AA0mqf77Tb2J/Ixrg/RyJuGITqt3KHYY5/1gIFsYsjnPtcPfh3GguxZiWrc/R3L4Z4upDYcJ/e1CF9f5hEh7dLKx/R0= X-Received: by 2002:a67:e319:0:b0:3b1:3601:2aab with SMTP id j25-20020a67e319000000b003b136012aabmr14987522vsf.17.1671226585825; Fri, 16 Dec 2022 13:36:25 -0800 (PST) MIME-Version: 1.0 References: <20221020182603.815-1-luoyonggang@gmail.com> <20221020182603.815-12-luoyonggang@gmail.com> In-Reply-To: Reply-To: luoyonggang@gmail.com From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Sat, 17 Dec 2022 05:36:14 +0800 Message-ID: Subject: Re: [PATCH 11/25] libcpu: Use __asm instead asm that can be recognized by both clang-cl and gcc To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: multipart/alternative; boundary="000000000000fcc94905eff8c28b" X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000fcc94905eff8c28b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 12, 2022 at 8:42 PM Mark Wielaard wrote: > > Hi, > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > Signed-off-by: Yonggang Luo > > --- > > libcpu/i386_disasm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libcpu/i386_disasm.c b/libcpu/i386_disasm.c > > index 599d1654..cc75a7b1 100644 > > --- a/libcpu/i386_disasm.c > > +++ b/libcpu/i386_disasm.c > > @@ -480,7 +480,7 @@ i386_disasm (Ebl *ebl __attribute__((unused)), > > > > /* gcc is not clever enough to see the following > > variables > > are not used uninitialized. */ > > - asm ("" > > + __asm ("" > > : "=3Dmr" (opoff), "=3Dmr" (correct_prefix), "=3Dmr" > > (codep), > > "=3Dmr" (next_curr), "=3Dmr" (len)); > > } > > Urgh. Is this really (still) necessary? It is inside an if (0) block. > So it also is never used. Can we just get rid of the whole block? OK, I'll get rid of it > > Thanks, > > Mark -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --000000000000fcc94905eff8c28b--