From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by sourceware.org (Postfix) with ESMTPS id 6B38E3858421 for ; Tue, 20 Dec 2022 16:31:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B38E3858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa30.google.com with SMTP id b81so6002118vkf.1 for ; Tue, 20 Dec 2022 08:31:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=T1/d2TbkIvwyDiCf1cqQ6C+qOvxgmKdjaC1dQbLFesk=; b=GYp3sH1zT8OeULPqMqjfI2ebvhuivkd+ulNIesRrtTqkds79QCzHKd6hoNkbiukl6J Tcg0deGoUBaKr8JUGairm3lCf92v6itJEphxgdHhRx2tGbmkPypB1owpKEy12xJE5ftU 1FmudxI/cB2IIo09cfOgoX8H4cqDv9jEU+/huQWddAXVQRKQtGYgt7Gp95htLCqQy0WO 99ubdRQkWW4AT8i5m4OP+M8UlA22YqwB4PLuh/zsCZ2Dmav2Btx4MB7IQ7Oa7crh0afl wZJXpVnDgZmWnywWqFQZcKdY8J9s/urpolWuI8468TH9/EpLbf8X20QsNQebzcBH5Xv8 RmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T1/d2TbkIvwyDiCf1cqQ6C+qOvxgmKdjaC1dQbLFesk=; b=grqXx/Q5nvWC/zV4FjuKZ39SO+zyb8a65SXOTrX2veOF4rxMCm6nMfyZsmuzi/tSOx P7Oolu59/bEwy37cY4pkvzoBN3AVAQFoWzZquXmYYtzcKawGOkRHb6ogD6lntfVNfjXm 0f4PVg6YNe0F3yWy8Ycv1JlawYLV63cVtfXMwX6fP0NyT0OBRQx0N2psRCLtmbPxchid QpFW2jN2ekaOdmFLAQ7AR14FiwFb4iSkM8XS4nVBOBAdgZW43M6eGQA234p1I5hM5T+S hbr3YFf6oysAxGVO9sectiTIEB6UnMw43j0QfDi/pPjab8GyWZFPOyyZF95QlK7pD9SM ywSQ== X-Gm-Message-State: AFqh2krsCSOxJoUuJMHqxxeAXvyGxgqbgE2Giptx1Bd1nVaKtg7ny8sL go+Zo/qbdl2TD4Wzitr+lLf0P9pj8bQPy6nl0GG0nXgD X-Google-Smtp-Source: AMrXdXuMf7/pQPlb5zWWoRiSsYI+F+q4eww+C1OKNIDyTzQQYAzdkmQnNANyiEgx62EqUI7C7/rPMbW0yWZyJ0U+Mvk= X-Received: by 2002:a1f:b68f:0:b0:3d1:2f5d:cba8 with SMTP id g137-20020a1fb68f000000b003d12f5dcba8mr1291998vkf.29.1671553867655; Tue, 20 Dec 2022 08:31:07 -0800 (PST) MIME-Version: 1.0 References: <20221020182603.815-1-luoyonggang@gmail.com> <20221020182603.815-9-luoyonggang@gmail.com> <58555b250db8b3f75abab545b3aa24226d0e23a9.camel@klomp.org> In-Reply-To: Reply-To: luoyonggang@gmail.com From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Wed, 21 Dec 2022 00:30:55 +0800 Message-ID: Subject: Re: [PATCH 08/25] Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: multipart/alternative; boundary="0000000000008130f805f044f6fc" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000008130f805f044f6fc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 20, 2022 at 10:04 PM Mark Wielaard wrote: > > Hi, > > On Sat, 2022-12-17 at 05:21 +0800, =E7=BD=97=E5=8B=87=E5=88=9A(Yonggang L= uo) wrote: > > On Fri, Oct 28, 2022 at 7:41 PM Mark Wielaard wrote: > > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > > > wrote: > > > > Signed-off-by: Yonggang Luo > > > > --- > > > > configure.ac | 1 + > > > > lib/crc32_file.c | 4 ++-- > > > > lib/system.h | 2 ++ > > > > libelf/elf32_updatefile.c | 3 ++- > > > > libelf/elf_begin.c | 5 ++++- > > > > libelf/elf_end.c | 2 ++ > > > > libelf/elf_update.c | 5 ++++- > > > > > > Missing commit message and ChangeLog entries. > > > > > > So this is for a system that doesn't have mmap? > > > How does the testsuite results look on such a system? > > > > > > ELF_C_{READ,WRITE,RDWR}_MMAP[_PRIVATE] are elfutils extensions, but > > > they are used internally in other libraries. > > > > I am trying getting elf support for windows/mingw/msvc, the MMAP support > > is not needed yet > > for (QEMU/mesa) > > I have to think what it means for a system that doesn't have mmap since > the mmap extensions are part of the public interface. And various parts > of the libraries depend on knowledge that they can read/write directly > from mmapped parts. Does it really make sense to try to support a > platform without mmap? Windows have mmap, just didn't have the direct posix mman API > > Cheers, > > Mark -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --0000000000008130f805f044f6fc--