From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by sourceware.org (Postfix) with ESMTPS id 265AD3864A39 for ; Fri, 16 Dec 2022 21:19:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 265AD3864A39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa32.google.com with SMTP id l17so1733338vkk.3 for ; Fri, 16 Dec 2022 13:19:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ushsGU/rxzszhb2WBForj03pB2040Bo6DHTYydPeeHw=; b=dGajLATli/qaaLyzkXck5mtfRIG9N1FD0uAamA31Jmn4OIxx/7uq4i6y8Jshjmbv1M OXhyKdVaQsJpMRhWHpfk7aO0WQnInCeQ1H7657xwRdebFkNM2czwGmVm/ySulYNz1iJj LlXPITcEDrFNaynxB982kIQ+rX4s/5Af7g3i3erY1Yqf97aglXAKCsy/FqE7CXxUI7sJ DjPqpm+oBepzlUVKRueRyVdL2I01T2aH+AIBKh1hgyDX+P5LOZko59TRAH/B93Z3YEJN IvudySzDpLHp4czdgshCrlchIm37maJRK/RaMiw9ktEiN/fCBKLEfAaFWZozvZ4HXhmc 6YdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ushsGU/rxzszhb2WBForj03pB2040Bo6DHTYydPeeHw=; b=RcJyZ5cwEZ3jKdTmjietWCvgPNJVbhVP5qKxXxDQXzioZtYQC/AHuOIhWnfJI+Ao+W QQo7+l4KQ0k5RgwzOvngy6NmRPzJzbetBGjlf1QUWKnVthunRR5mNuYErgr1O9gkYq8c xoP0YVTPHRVdtd7XsNhbd7+WJVCX22yNI+zx3y6zB+3MDmrORZcMhmBmpUTsZX81SFIE NL92rO1tuHMLANCmrakCVjPxAK4hREeX+fiw1igFfryEKCUZQSUVS3gxzghDLqg/HBuS dKYF21ji2Gx0VjcR4VP76olMKeIBTvGDlZXxksUOz9beNbgMAr6TeLeDoWx4h+yk1EUt TYAw== X-Gm-Message-State: ANoB5pmquFdyjP/WhY+4pAzdTH10kZCcWsoNmqQ4+tcXvgA306V0s2Qb F3XtkuW4zRWAmtoMfYMa9bm1rH7WL4nCbhJ8KCBcsDLp0gs= X-Google-Smtp-Source: AA0mqf4f2DyVq2CIEJAPIQGRBsBxrXlhzsy9Mq2XDecWaxs8/kZCVpYTyF1S5RYWqAlBqX3STtYhzSIl7k50a+aQErc= X-Received: by 2002:a1f:9c43:0:b0:3aa:e2ea:ad36 with SMTP id f64-20020a1f9c43000000b003aae2eaad36mr47579695vke.29.1671225581432; Fri, 16 Dec 2022 13:19:41 -0800 (PST) MIME-Version: 1.0 References: <20221020182603.815-1-luoyonggang@gmail.com> <20221020182603.815-7-luoyonggang@gmail.com> <19dc6579ce183b63a8956b17611e4a264d745b34.camel@klomp.org> In-Reply-To: <19dc6579ce183b63a8956b17611e4a264d745b34.camel@klomp.org> Reply-To: luoyonggang@gmail.com From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Sat, 17 Dec 2022 05:19:30 +0800 Message-ID: Subject: Re: [PATCH 06/25] move platform depended include into system.h of libebl To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: multipart/alternative; boundary="0000000000001ef6bb05eff88715" X-Spam-Status: No, score=3.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPAM_URI,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001ef6bb05eff88715 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2022 at 7:35 PM Mark Wielaard wrote: > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > Because all source in libebl #include , so #include > > in > > libeblP.h is enough, there is multiple memory-access.h file, so use > > relative path to > > include it properly, > > I am not a fan of the relative path trick, especially if there it is > clear only one is every needed. You also use it for other files, why? > I am respect the original code looks at https://github.com/sourceware-org/elfutils/blob/master/libdwfl/core-file.c#= L31 > Cheers, > > Mark -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --0000000000001ef6bb05eff88715--