From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by sourceware.org (Postfix) with ESMTPS id 36189384C928 for ; Fri, 16 Dec 2022 21:21:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 36189384C928 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa30.google.com with SMTP id f24so1725078vkl.9 for ; Fri, 16 Dec 2022 13:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kBfrws64g1d4MxiSDMah/wKPh1Yk7eBZ6XdNaBZiSUA=; b=lY47LNMtNIkCXVCWiBOeYvtzG48uhtmXBO+0TPMLSVnS9Ft0Lale890tYVPKgK0cHG wOQaj2fRA1JloRiy6+/HFC5FNCetix7lOl8JnbidGtbsrv0vnmd80EUnq8SZoHTAmz52 ny2XRRYUAB7K3v0z45OV0jS2eabKsEZ/A7nt09XTo58Ak3Nqeq3I1A+UsyesVrRaaJ0T pAdG8MaPpMgYmA2zL/WxT/WELQaRwDdnGcm5OaylRbUvytzsi+bokv4PjHia/G4Ysm49 v/oPeGiWMLWQNifx7zc/EXf0J8mws/TM3n1wIlEZ63pNrQhcq8dGQJz/UrYjOx5j0c6Z yo1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kBfrws64g1d4MxiSDMah/wKPh1Yk7eBZ6XdNaBZiSUA=; b=qWzzZiMT6PEpImrYg7FujtdM9jZ6C+bAef8L3Wx84xyk3vs+w25pcKMjlkKfwpPFMO MmosDd5ADFJ9VFDuF5hnBXOq28EU0pEQSK5++nhMKInBlpr/bZXL0o60jnOoFZ52uvMf zs/JYmwnsAyaiyk6sZGKOtT4NTtD94ehaSwvUD43bIY+F5hCvyA6HdvvTnxmDvo2NGpZ ZvwNQtEuj9jsgBQplzK/Vemq1lDhfWeRQ3cligsflqI8FaFnU0RW36QySsL1CWvL6z/D X1Zy23Z9dVKR7VWDxkUcq8fBB11ge03vjDWCVF7ysR+fpfCDZIgGeLRCasjGAgFsE6gY 2atw== X-Gm-Message-State: ANoB5plaO48BlZNWaslxwYqDUqjwzfSwPcF2183bArD2V6FvBmx564DM uBJ9uI0e7BsOcja+xJh14d1iUTeVHyrQQL4TL5MlXJ0J X-Google-Smtp-Source: AA0mqf6hGU/I7hvJ+zMHADQWoaVV1E8z//M+bhUYOWbQNzEBRZQIrudsrfXkErfuX4U2rBJmGH1nAZrWQRp4PWi5efA= X-Received: by 2002:a1f:38c6:0:b0:3bc:bead:a41a with SMTP id f189-20020a1f38c6000000b003bcbeada41amr38498537vka.8.1671225711506; Fri, 16 Dec 2022 13:21:51 -0800 (PST) MIME-Version: 1.0 References: <20221020182603.815-1-luoyonggang@gmail.com> <20221020182603.815-9-luoyonggang@gmail.com> <58555b250db8b3f75abab545b3aa24226d0e23a9.camel@klomp.org> In-Reply-To: <58555b250db8b3f75abab545b3aa24226d0e23a9.camel@klomp.org> Reply-To: luoyonggang@gmail.com From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Sat, 17 Dec 2022 05:21:40 +0800 Message-ID: Subject: Re: [PATCH 08/25] Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: multipart/alternative; boundary="000000000000dfbbd205eff88e8b" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000dfbbd205eff88e8b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2022 at 7:41 PM Mark Wielaard wrote: > > Hi, > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > Signed-off-by: Yonggang Luo > > --- > > configure.ac | 1 + > > lib/crc32_file.c | 4 ++-- > > lib/system.h | 2 ++ > > libelf/elf32_updatefile.c | 3 ++- > > libelf/elf_begin.c | 5 ++++- > > libelf/elf_end.c | 2 ++ > > libelf/elf_update.c | 5 ++++- > > Missing commit message and ChangeLog entries. > > So this is for a system that doesn't have mmap? > How does the testsuite results look on such a system? > > ELF_C_{READ,WRITE,RDWR}_MMAP[_PRIVATE] are elfutils extensions, but > they are used internally in other libraries. I am trying getting elf support for windows/mingw/msvc, the MMAP support is not needed yet for (QEMU/mesa) > > Cheers, > > Mark -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --000000000000dfbbd205eff88e8b--