From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) by sourceware.org (Postfix) with ESMTPS id CCDB6384E79D for ; Fri, 16 Dec 2022 21:12:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCDB6384E79D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa2a.google.com with SMTP id b81so1732206vkf.1 for ; Fri, 16 Dec 2022 13:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gJVScG81rV/VHjPbF920MwrfvkzU+qMOU9O1bhVMfGo=; b=mYNRCOvQR60S2b9MF5QVWa1ms1kMkjT3UywXmsQx5gZmGFEJY8/ZiyGpzY59tcmqM7 FLHqCn58Fh2VMTS/fu2tDWrtGTJX8/OEwb4gu2cYhDpNmASrkBms46y7gquVaqCGcH2Y 5h7tEXKnhOQ73XIB6NgnN/xbdHs3VMlItrG0gDxfBVWW00BTiyyzaDL1TEHbtyY4VNco M+1KQb3pxD4tUAZZwsrfIWTc0z4sI8AU11aSprRI/YFa0sjYrbQiRXbzH1tP6Gk9B3+c PPx6t+U8b73tWS2QO6BMB43Y4ezfxe28FrmKY7p4DN7KOYW1y9yvxZ1rMG/4NwFkCqjS J/pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gJVScG81rV/VHjPbF920MwrfvkzU+qMOU9O1bhVMfGo=; b=yJRxkNcVB3bGUz2UB1/6lsCFwn4Nd3hx5UbamHjnYtw5Ss6Set61WLiniKQ+5LdMyP cw9gdWb82zvErXJbhReQQdqEDiU358LW0f5cG7Cy8wccHEzbSNZekMwEUUMqh/McOMOR UO6jBCrnoX6wiqfOZoIteSEp2ObwdJgDWVAN9BC1MXgbkzaQ3SwOsPzmDh1lXwvMAw3a 2NXq2Umw15bB1HGZANKjtX+aHoGgwvmrMKBvCmVqsdbXfEKwV665ogBUXMJbBA+PnjFx rlzKvV67u1ynGtn7Jen4RUxx7Mrpz3kQIvpr5mDf7GoO96YQTYpsBm14DpT9050Fj1t2 OuPw== X-Gm-Message-State: ANoB5pkEhK7XPvGP5VIy/BIJqGcvypWbhTSqHec7VCU1i2rftnasJcIR 6ZeFXJMGojAHv5ZXaJt//ghDbgRhOC5HMtfJVdo= X-Google-Smtp-Source: AA0mqf4OfOyCymwh/uQ6f2SiHV4n2IIj1mhg0F0JfwrHmadJxrkX0Ih5PeijxM5f+w8mt6zLfza/VZRWOpv63QAZXsc= X-Received: by 2002:a05:6122:f88:b0:3bc:da16:c70 with SMTP id br8-20020a0561220f8800b003bcda160c70mr31133536vkb.12.1671225145046; Fri, 16 Dec 2022 13:12:25 -0800 (PST) MIME-Version: 1.0 References: <20220920084307.1696-1-luoyonggang@gmail.com> <20220920084307.1696-7-luoyonggang@gmail.com> In-Reply-To: Reply-To: luoyonggang@gmail.com From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Sat, 17 Dec 2022 05:12:13 +0800 Message-ID: Subject: Re: [PATCH 6/7] Fixes building with msvc/clang mingw/gcc To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: multipart/alternative; boundary="0000000000001c3d4705eff86daa" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001c3d4705eff86daa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I am not able running test-suite on windows yet, just getting it compiled at the very first step On Mon, Oct 17, 2022 at 5:21 AM Mark Wielaard wrote: > > Hi, > > I find this hard to review. I have no experienc with msvc and don't > know when/what _MSC_VER implies or how to verify system_win32.c. I am > also a bit worried that the various ifdefs will be hard to keep > correct. > > If we don't have HAVE_DECL_MMAP does the testsuite still work? > > Maybe this patch can be split up is separate concerns. But I have to > admit I am a litle afraid this will be hard to keep working. > > Cheers, > > Mark -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --0000000000001c3d4705eff86daa--