From: Daniel Thornburgh <dthorn@google.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: Local Build ID Directory Lookup (DEBUGINFOD_LOCAL_PATH)
Date: Thu, 1 Jun 2023 16:51:53 -0700 [thread overview]
Message-ID: <CAEdiOye80esZhEDOdpoG7jRSNCJuKboNUDDQT0++tNeSAU4VTA@mail.gmail.com> (raw)
In-Reply-To: <20230601212101.GA3687@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
SGTM; I'll see if I can write a patch to do this when I get some spare
cycles.
On Thu, Jun 1, 2023 at 2:21 PM Frank Ch. Eigler <fche@redhat.com> wrote:
> Hi -
>
> > Hmm, how would the effective behavior of this differ from directly
> > returning the path? The symlink could become invalid at any time [...]
>
> Effective behaviour is about the same, but code logic and explanation
> is simpler.
>
> > It would make sense if the cache were made to contain a hard link to the
> > file if it were on the same filesystem as the cache [...]
>
> And this could be a QoI implementation detail: prefer hardlink, fall
> back to symlink.
>
> - FChE
>
>
--
Daniel Thornburgh | dthorn@google.com
next prev parent reply other threads:[~2023-06-01 23:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 22:17 Daniel Thornburgh
2023-05-31 22:35 ` Paul Smith
2023-05-31 22:35 ` Frank Ch. Eigler
2023-05-31 22:45 ` Daniel Thornburgh
2023-05-31 23:04 ` Frank Ch. Eigler
2023-06-01 14:58 ` Frank Ch. Eigler
2023-06-01 20:54 ` Daniel Thornburgh
2023-06-01 21:21 ` Frank Ch. Eigler
2023-06-01 23:51 ` Daniel Thornburgh [this message]
2023-05-31 23:44 ` Roland McGrath
2023-06-14 15:57 ` Mark Wielaard
2023-06-14 19:43 ` Roland McGrath
2023-06-19 11:53 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEdiOye80esZhEDOdpoG7jRSNCJuKboNUDDQT0++tNeSAU4VTA@mail.gmail.com \
--to=dthorn@google.com \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).