From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51050 invoked by alias); 13 Jan 2019 00:38:06 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 51034 invoked by uid 89); 13 Jan 2019 00:38:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=desktop, companies X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mail-vk1-f194.google.com Received: from mail-vk1-f194.google.com (HELO mail-vk1-f194.google.com) (209.85.221.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Jan 2019 00:38:04 +0000 Received: by mail-vk1-f194.google.com with SMTP id s184so4133101vkd.6 for ; Sat, 12 Jan 2019 16:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UiJ/0q52izZWWM4zDJcaOBqrBzjLWNFJzod/wKTqTEc=; b=EJFWEv0IQzycX50+uY1E/CNa9nfLShzWTRe1fb9mZbe3GNOrRhrnJBXqita3ZaA8vE KWV4DNKwcwbRte4Kgc/WngUGiQtWXwFW2wXLfTmrnFu/LYW7jZIvxhAX+5kL49/Q+9Ai v3pxJ+kvvvljjeNHCoVE2dwCwI3z3ucK/ye2Mn7VlHLVioBHNg344m6bmEYLdbMoT1lD 7K/O8A7R68VfHfV/7xOQP8PYcvjBMIMXe2QWE0W1GgOdBvPGCkDWKIBGI2fd+IW/ycOk iqtXzSQAeMxfTuv1cKKO11LClW3gcmCfq29MTW3w7syiO7friv6ZV/zd/EMAQc3LTf4r rIZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UiJ/0q52izZWWM4zDJcaOBqrBzjLWNFJzod/wKTqTEc=; b=jePweroBf4h/Lk5y7rAXpVK51Po4kfSPQcAk39WG7ZM3lrLIjfzv6JhFDUlZ4g6w+f oP5vJ/0mBpJhMvoRyXZzpc4no/WU8wkhfnQvcuY4TdTcCmZjfNicfVUZuVgApZYT9OGq BDoDwUyvOEYOwDlQ4LpTurtqMYzUnrTG7AXciQRe+dTSIK17LnGvG2h4Z54V3eHm3eqi yFoyblK/rZ5yJ+5ud1Lj9L6V2rsNHsAop9ZXtsdWyoKPQ6FN35EGPyiu3ulpMfsWqI34 xzJmUQbmvlzEooVoJtGKpAxr9Q8zbFyRbxbxsxb8xlHKydG4iEBGFV6rOLlHInZH05UE I+XA== X-Gm-Message-State: AJcUukfykVSH+tVoSwZ/fm3e9fX0CwrDE4Gq+u2RyKdJcKf7812KAk2P feY0U8c0hvWJvn1NMo4214w5rpSkRrjTFNrs48wJvUaT1js= X-Google-Smtp-Source: ALg8bN5SIw4n+QclA3SbCyKfCI+9XhUTGPr4Tbt30ljpA+7uwIJ8CPYutwObXOxZLgaD9riYkLnHKHlYIRsdU3y30HE= X-Received: by 2002:a1f:f8cf:: with SMTP id w198mr7720196vkh.82.1547339882772; Sat, 12 Jan 2019 16:38:02 -0800 (PST) MIME-Version: 1.0 References: <20181227232702.16823-1-jimw@sifive.com> <610f78bbaaa4558d69b6c20e244a0b8416f3c3a7.camel@klomp.org> In-Reply-To: <610f78bbaaa4558d69b6c20e244a0b8416f3c3a7.camel@klomp.org> From: Jim Wilson Date: Sun, 13 Jan 2019 00:38:00 -0000 Message-ID: Subject: Re: [PATCH] RISC-V: Add untested 32-bit core file support. To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-q1/txt/msg00031.txt.bz2 On Sat, Jan 12, 2019 at 2:29 PM Mark Wielaard wrote: > I don't really like adding code that cannot be tested. But it does look > the 32-bit port isn't far off, just waiting for the next linux/glibc > release to settle the time_t ABI. And the code does look correct. > Except for... We don't expect 32-bit desktop linux distros, but there are folks that want 32-bit embedded linux. A few companies have gotten it working, but only Andes is trying to upstream patches so far, and as you mentioned that is waiting for the time_t ABI. Meanwhile, it should be possible to build a busy-box style 32-bit linux system, using an old obsolete pre-upstream glibc port, but that isn't useful for real development work. > > static const Ebl_Register_Location prstatus_regs[] = > > { > > - { .offset = 8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */ > > + { .offset = BITS/8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */ > > }; > > Should that be .bits = BITS ? Yes, sorry, I was looking at the offset field and completely missed the bits member at the end. Do you want me to submit an updated patch? Jim