public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Conrad Rad <cse.cem@gmail.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: dwarf_aggregate_size() seems to fall over on pointer types
Date: Wed, 01 Oct 2014 14:34:10 -0400	[thread overview]
Message-ID: <CAG6CVpXYVwai2JpUg2_hfFtnmpZ4WoCg0i+HExuSAZFqLwx+Sg@mail.gmail.com> (raw)
In-Reply-To: 542C3E0C.3000503@redhat.com

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

On Wed, Oct 1, 2014 at 1:46 PM, Josh Stone <jistone@redhat.com> wrote:
> On 10/01/2014 10:15 AM, Conrad Rad wrote:
>> I've compiled a small example program, repro, and output[2]:
>> http://pastie.org/9610702
>>
>> dwarf_aggregate_size() has no trouble with most member types, or even
>> pointer types on the output from GCC. However, it returns an error on
>> Clang's output.
>>
>> Perhaps Clang is just eliding pointer size information, assuming
>> consumers will consult the Elf machine class and infer?
>
> Indeed, clang doesn't seem to output DW_AT_byte_size on any
> DW_TAG_pointer_type, but gcc does.
>
> FWIW, the DWARF4 Appendix A does *not* list DW_AT_byte_size as being
> applicable to DW_TAG_pointer_type, nor DW_TAG_reference_type, nor
> DW_TAG_rvalue_reference_type.  However, that is just "informative", and
> producers are free to omit some of the suggestions as well as add their
> own, so it's not an error that gcc produces DW_AT_byte_size.
>
>> Am I missing something? Is this a Clang bug or an elfutils bug?
>
> I don't think it's strictly a bug in either.  Clang is not required to
> produce byte_size, and elfutils is just reporting what it knows.
>
> Still, it might be nice if elfutils made that machine-class inference
> for you.  (But I worry about things like that mips pointer issue
> reported recently.)

It'd be nice. If it's just pointers and arrays of pointers, I can
cobble a fallback together. Members that have struct types with
pointer members should get their own size information emitted by both
compilers, I guess? (Both generate size information for 'struct b'.)

What was the issue with MIPS pointers, by the way?

Thanks,
Conrad

             reply	other threads:[~2014-10-01 18:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 18:34 Conrad Rad [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-10-02 20:56 Mark Wielaard
2014-10-02 12:50 Conrad Rad
2014-10-02 12:05 Mark Wielaard
2014-10-01 20:33 Roland McGrath
2014-10-01 19:26 Conrad Rad
2014-10-01 19:23 Conrad Rad
2014-10-01 19:10 Conrad Rad
2014-10-01 18:47 Josh Stone
2014-10-01 18:33 Mark Wielaard
2014-10-01 17:46 Josh Stone
2014-10-01 17:15 Conrad Rad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAG6CVpXYVwai2JpUg2_hfFtnmpZ4WoCg0i+HExuSAZFqLwx+Sg@mail.gmail.com \
    --to=cse.cem@gmail.com \
    --cc=elfutils-devel@lists.fedorahosted.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).