From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 0470E383F423 for ; Thu, 8 Jul 2021 17:58:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0470E383F423 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=immunant.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=immunant.com Received: by mail-pf1-x42e.google.com with SMTP id x16so6196109pfa.13 for ; Thu, 08 Jul 2021 10:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=immunant-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KzF0azt85E0MuSmxwESS69SePTA+u/wFQ9GUwWOG8xc=; b=wnVQcEt32Ui1YECZ4a+k2lR2i9+jvgeMZr0TXXiwziB3RcLz3+CO2MFA7lH67RLuX/ yhc0Siw6rAkBHIstqQbjbcLBdLy2E0lQ+BP66+cgOoIY7oSd5F+Fw8bKFvoIbJc9TuHm sTVRQL6lbC+ZZcvPqIg6jVWHMGQH5Vj6GOoLr7k0114PgWiFfgyn4/oqEKzzes8TjD9s LrS4wNI/qOudJOMOLJj8pswEvCRWcGEiIvC7NlQHQ7H8eatp6fzFB497YKIB0q++R7wl 4DmS4bqBh+qEoLKAjsJRul8mcL4GqdtkSf6Gk5QW+ojHdkxeGEtKerAbcfVPavK0a6LS qmBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KzF0azt85E0MuSmxwESS69SePTA+u/wFQ9GUwWOG8xc=; b=qADwuDLsfwTpeolFg8sTj7wd6WYOeZ9i+vnw3OAcksH+jbURBONm0PScnwsQZqpoJb pKVtV/ZBAgfwuA3UhJONWLSR9YYoviWF7ReNh0hQVjaLJUHnuR1+Wrl9kqdPQX6GUR3C q53+q1nlj/UY1LdaZ42wL5nHuFDMwf1mmhUjaXCWS64CwOCUcTxub9SEk/0a2eLxBkPl OnhL6eyOrX6ZGde82GxJaX5WOIXwhQBrHm7GfIqLnF0BPjMJcYQJGR+WnAzQ37/2cTMr 22Q5QG1c9+8FltA5xjuP56C8Qxv0j3t9PNdhIUJTkfgaFtOHxTFJw+tbNBng/1+1ETmU fZ4g== X-Gm-Message-State: AOAM532daoxQdghIalizruH+tMIvgo0dkc9yEFWHUPk395tkJrXDfaXU fsNgboxABIMUi/9x5UHcU8Kw8jGGG2RYwDLS4354/lNlbEN/NQ== X-Google-Smtp-Source: ABdhPJx8fAQvpq2Ys6onOO1mBo5wafD0vb4HRqfMCr9JO+Mse9JGe84jnMQxXpzuF0C1nhBAYYsFuXbrbyVPwqpYE3I= X-Received: by 2002:a65:6412:: with SMTP id a18mr32461592pgv.445.1625767118112; Thu, 08 Jul 2021 10:58:38 -0700 (PDT) MIME-Version: 1.0 References: <20210629012653.2375942-1-ah@immunant.com> <9d78443192899df450e3f1128b7692c55e3e6bf6.camel@klomp.org> <086caea17d4700ae2d6ead8d722906002bdcb475.camel@klomp.org> In-Reply-To: <086caea17d4700ae2d6ead8d722906002bdcb475.camel@klomp.org> From: Andrei Homescu Date: Thu, 8 Jul 2021 10:58:26 -0700 Message-ID: Subject: Re: [PATCH] libelf: Fix unaligned d_off offsets for input sections with large alignments To: Mark Wielaard Cc: elfutils-devel@sourceware.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2021 17:58:40 -0000 On Thu, Jul 8, 2021 at 2:37 AM Mark Wielaard wrote: > Hi Andrei, > > On Wed, 2021-07-07 at 13:24 -0700, Andrei Homescu wrote: > > I wrote this patch on behalf of someone else, so the copyright line > > should be: > > Copyright (C) 2021 Runsafe Security, Inc. > > OK, changed. > > > > The testcase already fails before the patch and succeeds after, but > > > it would be nice to double check the output with elflint just in > > > case. Shall we add: > > > > > > testrun ${abs_top_builddir}/src/elflint --gnu $outfile > > > > Sounds good, no objection from me. > > Should I submit an updated version of the patch, or can you add this > > on your end? > > I made those two tweaks and pushed as: > > > https://sourceware.org/git/?p=elfutils.git;a=commit;h=b3601167d7a4c9f34eb65c3892c9ef25e3c1c66f > > Thanks, > > Mark > That's great, thank you! Andrei