From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76567 invoked by alias); 15 Nov 2019 17:03:42 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 76510 invoked by uid 89); 15 Nov 2019 17:03:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=percentage, HTo:U*mark, notified X-Spam-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Nov 2019 17:03:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573837412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TSfOsND1Mvm35UFO8EyC1l+tiZEggciqdm0ygIfwF6w=; b=i+0rFOiEygYwwgb2bSWH1Csg0oj4dBJBEeWEQW162dcdFYiKIcmkG7pSnpReGMxeBdxkcw c62Gkk5IrP58TMYWpzb6XMMbZluRaldF66QDpjimxDrFXt+2cb9LcGD3KdX0fanPtVJN1L p4QNg+MEJyp0J8Ry0zPmi0ywDQwkbVs= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-0_fePLY6Nii7VnVhok5CMA-1; Fri, 15 Nov 2019 12:03:28 -0500 Received: by mail-ua1-f71.google.com with SMTP id m10so2473863uan.9 for ; Fri, 15 Nov 2019 09:03:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=deOqM/XJU1xQPMtoQKi2D3vq+H4gFkPdAG0vJY0zvBM=; b=Dp5bNJhDo6/3jgcCcvivNbg7lpHQ2+blMiTzV86+PThQDHw6qGR6fo+lpMo4Fj3ixI fxyF4n7QhgNMSr6wBtiPYuTLdaZp8Xvcl27qztBHLVoX8WLgdbl2hhdYQF+M44Y9C4PC vB9vC9YNStwOVlgFPGoZP9ZPDkB0wLfDO2tWO6ljJZX61+mQMj0G8zkuOZOyqytSF6/o u/jJ387laElRjsB6b2j4e5t0cU3/q7qYTULN+EBkBrPfuF9+L7awXyyg3tQuFwHQL67O 5ZsuSQVljdHEV3+RB2JoxCsBL7KYybXJCGIDE8LO5hZqdAq9LA93I9h0MQl5mkI3IX0j 5h8A== X-Gm-Message-State: APjAAAWXPv0CXhvQfzpY2UxtSDmaW1J02NLZl80e0bnjQog6BnYsXU40 xHoUpT38khiLzKn5HOKVajkzsltVuIK6+iHrDuh7B1P1TtmoKUuV7Kbm8mvZdlgZpeKCgHmPq3u q03V20jH5xtHJCdCD0D+PCYW78NeY7eKQWQpvAFPU X-Received: by 2002:a05:6122:301:: with SMTP id c1mr9317700vko.42.1573837407512; Fri, 15 Nov 2019 09:03:27 -0800 (PST) X-Google-Smtp-Source: APXvYqxm/a131D+cL9/hLhTys3tjw/kfQ5+AsfIe/fyLwEWxIBtbvbMsYyFpDugwqyHeDRZyEQMwOmP/BUpsMN82ciU= X-Received: by 2002:a05:6122:301:: with SMTP id c1mr9317680vko.42.1573837407166; Fri, 15 Nov 2019 09:03:27 -0800 (PST) MIME-Version: 1.0 References: <20191028190438.GC14349@redhat.com> <20191028190602.GD14349@redhat.com> <20191028190726.GE14349@redhat.com> <20191104214823.GA17633@redhat.com> <73de7c5ac7205dbb5e6d4c47a2abb0c23cd79d5e.camel@klomp.org> In-Reply-To: <73de7c5ac7205dbb5e6d4c47a2abb0c23cd79d5e.camel@klomp.org> From: Aaron Merey Date: Fri, 15 Nov 2019 17:03:00 -0000 Message-ID: Subject: Re: patch 3/3 debuginfod client interruptability To: Mark Wielaard Cc: "Frank Ch. Eigler" , elfutils-devel@sourceware.org X-MC-Unique: 0_fePLY6Nii7VnVhok5CMA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00143.txt.bz2 On Fri, Nov 15, 2019 at 11:16 AM Mark Wielaard wrote: > On Mon, 2019-11-04 at 16:48 -0500, Frank Ch. Eigler wrote: > > At the wise counsel of gdb folks such as and : > > > > debuginfod 3/3: client interruptability > > > > For interactive clients such as gdb, interruptibility is important = for > > usability during longer downloads. This patchset adds a > > download-progress callback function to the debuginfod client librar= y, > > with which a caller app can interrupt a download as well as be > > notified of its quantitative progress. > > I have some concerns about this. It cannot be associated with a > particular debuginfod-find request. Good point, maybe we should add a progress function to debuginfo-find, or include a default progress function with libdebuginfod. Maybe one that prints the url where the target was found plus the download completion percentage every few seconds. > IMHO it should have an extra argument to indicate which build-id > and request type exec, debug or source (+path) the progress/callback > was for. I think we could add this information to the progress function output without changing the API. But if users would like more control over how this information gets used in the progress func maybe it's worth considering. > Also this one global progress/interruptable hook. Which means it > cannot be used by e.g. libdw and an application that uses both > libdw and find-debuginfo directly. I wonder how often this kind of situation will come up. If it's very infrequent maybe it's enough to simply flag this issue in the docs so users know to avoid it. Aaron