From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8B3813858D33 for ; Tue, 6 Feb 2024 20:21:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B3813858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B3813858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707250890; cv=none; b=FF1oRcGcAfwaqfqo9tWb6APUg//2XwUpJsNmsm2f3cbqhzHIvIsYtJp3Pmmd9QIRqmlFJh28cNaB2ti21yVimH3ISPYSCSfv9rCZzyTiVAvi6MgI80cFTDHguXSdtstKYDkSDsskoSBTpuC9lYVy+pJUWAUV2zjNrwnWI6yGZiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707250890; c=relaxed/simple; bh=OgMy6vfSWnhsW+X+mpY/nHf5pWuDOEfOlsWnqPGIsM0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Ne/+7ofMq5xf3GJgCcjXmuWtn0TB09Ialkx/g04AvKAK7x6aUS5n0aEmiBuj1AIvipNPq2/GuXjY6m9N1WyA8G/hNHhhVuuSaXZjIjqqF7Z1D3wahuVh6eKDwH5jQCDR5lfoHzvNPF0hzgOcfwvW+l4cQzOyiMIM3J8pGSJM0hI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707250888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Af9gltDfAaN2A/QjPB09uAaexLgteHPKNDOsAXoOZbI=; b=UBgozPvXpvPSsVv47LCrNEiJ6NzHpEVN8W7eNa+59jYabzXWtjExSJW2tE8ofDyEds0Xdu cTyUeURakz6sZJZlVKevd9MXLw9ZWr+9tcjdasvDsoM0jz45OKhsvzCrU8QZNoczwOedxA +vhpkgFrDfuuiYgIcZkj++jO7DtH6rI= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-107-MM6MmUpoO8GPoK4hHN9heA-1; Tue, 06 Feb 2024 15:21:27 -0500 X-MC-Unique: MM6MmUpoO8GPoK4hHN9heA-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1d4212b6871so73052405ad.0 for ; Tue, 06 Feb 2024 12:21:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707250866; x=1707855666; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Af9gltDfAaN2A/QjPB09uAaexLgteHPKNDOsAXoOZbI=; b=l9d0ztFLuM8ptYMs8so2dX26MrCvXfyoARDFg/XX+BdPkbeOAF4ktq1C8LV5DJkjIp cZWFVx34elaePpgoHoHOBIJ/5v1mY7w5mTxjcQ6HogSQsbwo2Sn0Ocmo1SC/QuvyJRJ9 D2Cw94mp7MMtjifGx6THPjmWiIIv3UIV89LWVIqXpbCgOD9LKNPU86Cwl1rDudN0idH0 mJonz+zMMxt89uSz5OyB0hXNW2nwBfDrb2uf8P98tJR6fA73uNl9zXY4HYxgoKdhTEuI gYsNbS5LO6NleJbV5GAzOgrA29Dq6Og9tajDwiucY/T8H3xiGSTgiVT9+/MUS0HLqfDo 5W8w== X-Gm-Message-State: AOJu0YzqUMAPUi89A4NleTkhJCmoh9OMfaWwbbPVNGcROmisDk9edywp NTCMkm98FnkqfhPQJOiBFcWgtJHLgeMvFsiMx8dXp4WSwB2tMnQVWYRlRDfaYFxrX+L+h3iohdv j8i27nVEpcUrg0GsoI6dPyWK81/5x0dbjrtUvqjcjq020y+3uxBcGbDzog0mCaN5CwBqXTV271C 4XG+/F83NTDkA9NjbTa0SWeJDYF00dY7fDjD8Snoh/g3MhOOY= X-Received: by 2002:a17:90b:4c46:b0:291:2:688 with SMTP id np6-20020a17090b4c4600b0029100020688mr714678pjb.39.1707250866148; Tue, 06 Feb 2024 12:21:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHg80ngvkBjvDe3f2mcHqNN+LY/RAq3d3VzHAyZdi7gvH9HP4DXLPVR1BfjFCnLR+ph/gQbNlo1eCs/9qEAjsA= X-Received: by 2002:a17:90b:4c46:b0:291:2:688 with SMTP id np6-20020a17090b4c4600b0029100020688mr714667pjb.39.1707250865861; Tue, 06 Feb 2024 12:21:05 -0800 (PST) MIME-Version: 1.0 References: <20240205231104.125617-1-amerey@redhat.com> <57dfde9ef230833179dd9b220f7cc93ec2ab7086.camel@klomp.org> In-Reply-To: <57dfde9ef230833179dd9b220f7cc93ec2ab7086.camel@klomp.org> From: Aaron Merey Date: Tue, 6 Feb 2024 15:20:54 -0500 Message-ID: Subject: Re: [PATCH] unstrip: Call adjust_relocs no more than once per section. To: Mark Wielaard Cc: elfutils-devel@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mark, On Tue, Feb 6, 2024 at 10:36=E2=80=AFAM Mark Wielaard wrot= e: > > So it looks like elfcmp explicitly checks ebl_section_strip_p and > doesn't compare sections that are strippable. Maybe we should add an > eu-elfcmp --all-sections flag? > > We should probably also check that it handles the new SHT_RELR sections > correctly. I see it only checks for SHT_REL and SHT_RELA in the code. > Although RELR is really simple and doesn't have symbol references. So > it is probably fine. I added a PR for this: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31= 345 > > adjust_all_relocs (Elf *elf, Elf_Scn *symtab, const GElf_Shdr *symshdr= , > > - size_t map[], size_t map_size) > > + size_t map[], size_t map_size, bool *scn_filter) > > { > > Maybe bool scn_filter[] since it really is an array? Done. > Looks good in general. Just clean up in the new testcase and run it > with testrun. Done. Pushed as commit 2f9b180cc1. Aaron