From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1E77C3857836 for ; Fri, 15 Mar 2024 17:28:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E77C3857836 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E77C3857836 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710523683; cv=none; b=sBXCvHJT2uw7FfxOLjIYlb6jtgb19fhkn7Wru0sTygrHnLsjEos5j/rhtb0VGCb/caXcPLyrr+51pliGON571pEJcHLIA9VPVT1WadAvY2KljHia6Mba/TrphfcHLamOBK9wZX+C/6ahrvW0NsIomIiggflkEJXoMt17VgBqjRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710523683; c=relaxed/simple; bh=RGgetRZxqTdLcWIS/GqNcuhGZJFPFhewdBIsvHqmuSI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=OEGMwoGMe1/lhnH7ZDjs34m/mBTgvsM3GPg76jGFkXfAM6fSxb3R5UrzvpVzQZd07SleCdShCURe4aJjmHvz2GQerHGNdmLHazbXOpf+F15Te/8o1YzKlL2gPOJ9XIHtwkNYbvB4szfUxW3xuUWA32A3irOYs1l5gSJG3FBBsHQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710523681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B6F7g/+sMPk0JXhOHqXV6r5vejxqnqgkgju+3hYAWxc=; b=B+Kqb3LGcYteqcxAtmq6Ue4gpi6n0oaWCncNL9if8I1qHBj05gAHdem7RhJ5szQvYCoPsX b++evJVHF6sTtnKbuM1YYL5Ko1hQzbXPPG+XPp/h8RWt9FT9kskQ66yTPoG/s1ODu6UqCN D9LO7gRtuPLVfCXhjiHlwmKsksQfJEs= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-tO-h6Fo8MOyxugr3fi1UVg-1; Fri, 15 Mar 2024 13:28:00 -0400 X-MC-Unique: tO-h6Fo8MOyxugr3fi1UVg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d4785bf2cdso19168191fa.1 for ; Fri, 15 Mar 2024 10:27:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710523678; x=1711128478; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B6F7g/+sMPk0JXhOHqXV6r5vejxqnqgkgju+3hYAWxc=; b=s39rE/PfFdjnYbK6ikW4XtGMRJytMPv6lfMY4KX8YRipq3mTpndNs3iqq1Zt3OFb8S rQE33mR8GzoLedOlSqoUUCPcVdXDr2uLIF3e3zydwUxGUDsHM3fyjUKdLxj5SWTNxGsz OP46ZYOssVYTpLalIYt7jk57s5XY/woMrXgtckhdP++PgtAhP80QKaCjb6TjQCSKoSdB CZzj+YeVGB7En0ubS084dxxTRYUfjsmJumP+dDkfs41aMhwW/8z7fWZDtQ9ZBd5KDHI5 PQxI1TeFjUYh4I3QVR8gi4j0wTZMFtqWD6/B7cCp21Lxetwmd9aITZsfDnL/hTZJYuq1 KwnQ== X-Gm-Message-State: AOJu0YwuS27A7ZOOANon1QxVC+rJoyZCgHPhpVKMARd1EUwcIZZpwcHd +gg3ybZx9gbpxQyKMRn5K98rRLZifxcuNqIP7BT9BwTinqLlbvYWz+Wv+Na0drIBfkYP9ZkqUKw q/Diy1N+KS2P8ooHYju1NzOt8Glx+3fYsxqTYGyFk5ukwZcaIyDVmHSOo2QueeXjdnIK7fGYWkU jPdZAscKCbsGnR1L5kIrk+q+cE6kwG32HSp1O1 X-Received: by 2002:a2e:8687:0:b0:2d3:f013:61d9 with SMTP id l7-20020a2e8687000000b002d3f01361d9mr3886395lji.31.1710523678517; Fri, 15 Mar 2024 10:27:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGt/gQ3CJfHr70PFeu8NkeTMwxEkeVu1PhQ+z2YvI5InToKcn4evFuD3Q7/h5DBKHfmpFrgGdF6p2tQ2nHFwKw= X-Received: by 2002:a2e:8687:0:b0:2d3:f013:61d9 with SMTP id l7-20020a2e8687000000b002d3f01361d9mr3886379lji.31.1710523678033; Fri, 15 Mar 2024 10:27:58 -0700 (PDT) MIME-Version: 1.0 References: <20240306192249.242130-1-yakoyoku@gmail.com> In-Reply-To: <20240306192249.242130-1-yakoyoku@gmail.com> From: Aaron Merey Date: Fri, 15 Mar 2024 13:27:45 -0400 Message-ID: Subject: Re: [PATCH] Getter and setter for Dwfl's offline_next_address To: Martin Rodriguez Reboredo Cc: elfutils-devel@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Martin, On Wed, Mar 6, 2024 at 2:23=E2=80=AFPM Martin Rodriguez Reboredo wrote: > > diff --git a/tests/dwfl-offline-address.c b/tests/dwfl-offline-address.c > new file mode 100644 > index 00000000..9a33b95a > --- /dev/null > +++ b/tests/dwfl-offline-address.c > @@ -0,0 +1,43 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include ELFUTILS_HEADER(dwfl) > +#include > +#include "system.h" > + > +#define OFFLINE_REDZONE 0x10000 > + > +static const Dwfl_Callbacks offline_callbacks =3D > + { > + .find_debuginfo =3D INTUSE(dwfl_standard_find_debuginfo), > + .section_address =3D INTUSE(dwfl_offline_section_address), > + }; > + > +int > +main (int argc, char **argv) > +{ > + Dwfl *dwfl =3D dwfl_begin (&offline_callbacks); > + assert (dwfl !=3D NULL); > + > + if (dwfl_get_offline_next_address (dwfl) !=3D OFFLINE_REDZONE) > + { > + dwfl_end (dwfl); > + return 1; > + } > + > + int result =3D 0; > + dwfl_set_offline_next_address (dwfl, 0); > + if (dwfl_get_offline_next_address (dwfl) !=3D 0) > + result =3D 1; > + > + dwfl_end (dwfl); > + > + return result; > +} This test needs to be run under a testrun command in a tests/run-*.sh scrip= t in order to have the result recorded by 'make check'. Also there are a few places in libdwfl/ and src/ where we manually set dwfl->offline_next_address. We could use the setter here instead. Aaron