From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 77D6E385801B for ; Wed, 13 Apr 2022 19:18:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77D6E385801B Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-dVac8ZLCP1qgtz9jFGuY1A-1; Wed, 13 Apr 2022 15:18:21 -0400 X-MC-Unique: dVac8ZLCP1qgtz9jFGuY1A-1 Received: by mail-qk1-f198.google.com with SMTP id g15-20020a05620a40cf00b0069c61283d9fso1209659qko.20 for ; Wed, 13 Apr 2022 12:18:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q0nejqpCfQe76EPgkt/BDBsfsKiKtSE/YarDZ21nEcc=; b=eaooQ22C55jSoR+0JzfAkfqGEJjxO4wrtqrDNN1bCnpVTOjZIPdiEdhiBnamHRtocP GDOY/IaGAoCD9DGGUWrguiumlT3vFflsxDe6ovAKr0TRcjxiiWk3v4V03jRwD9/tB2Sy C6JzldoCAg6t2M4DX/n6opElFkrJRV/IRPMSXWMxWZmVVB9nWfQ2JejSSnbD9ajO24E0 xlDWwuOfhff2YjTighHJTDvZ6R9Qyby0+4EEZvW/6sIUyq61vv8Xd8eypkKqukqfFHU+ tmjsxZ+vo5R1s/lJBUpfKi8xPF16JG0/ofhjWnQghcxmmf/AzuHBjq4oemblZjQ8JtZD OcPQ== X-Gm-Message-State: AOAM532Irizgv8MUeBL9Gr0FCVzOFrQTKJL9TriB9LIFiqvWzkgAFskh 8VScO7LhSuUKcwOmvkMsqJG3SshA3OuXLpkAm5ITfwK3V9A4onbeUAJDJBJACDb3Abb3p9VsI5l lK4gjErfTQoH4qhixqUIgs8lR+JAT2SNsvCvY8Xwf X-Received: by 2002:a05:622a:22a4:b0:2f1:6709:be05 with SMTP id ay36-20020a05622a22a400b002f16709be05mr5292528qtb.322.1649877500556; Wed, 13 Apr 2022 12:18:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzY4mRPBlHn/spw8vU20P7pdw97ur3CbKcUxINvTnAsd/acx6FK9+dQyj/GamZjvx+5fggnDE+Vh8+HbCCn79c= X-Received: by 2002:a05:622a:22a4:b0:2f1:6709:be05 with SMTP id ay36-20020a05622a22a400b002f16709be05mr5292516qtb.322.1649877500372; Wed, 13 Apr 2022 12:18:20 -0700 (PDT) MIME-Version: 1.0 References: <20220406003407.292374-1-amerey@redhat.com> <20220408233711.62613-1-amerey@redhat.com> In-Reply-To: From: Aaron Merey Date: Wed, 13 Apr 2022 15:18:09 -0400 Message-ID: Subject: Re: [PATCH] PR29022: 000-permissions files cause problems for backups To: Mark Wielaard Cc: elfutils-devel@sourceware.org, Milian Wolff X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 19:18:23 -0000 Hi Mark, Thanks for the review. I fixed the issues you pointed out (good catch re. setting rc before closing fd) and pushed as commit 8b568fdea8 with Tested-by: Milian Wolff added. Milian, thanks again for taking a look at this. Aaron