From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 03C9D3858D20 for ; Wed, 17 Apr 2024 18:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03C9D3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 03C9D3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713379604; cv=none; b=qTagJPYgRAnNhBY9oC1I+/o9CCFe0hkNDMyppEdEtVUFH0aWKX/GeUuwNXdBcfcx9WXwzvdRDMZLr1KwBPCFN2mK5dOvBTnD8CDTVcyk9So37SYM93gPj4BoRgahQbfPX2+lOyryRvVyqn74JWJCPJRPz5O/MvfIJbmT6PC+//s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713379604; c=relaxed/simple; bh=HeDrV095npQpdFhNpr8IxHkLY0i/rnThkTujq3HNS6A=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=KQLDxwuMXdirnl2XBLytKyRt4tASsPOC02edzAn3QMABYbWJbKRlOiEFvXCjX/uxEitTToez0DIPU0BjYob0DQEPX0yX0Ve1j0shb79qpYLCZmwNPCiDbCqFogEEY6wTajI1/Qi1Ef7lxgVdpGFkdUsLwqi71+fQXzcncF4fCnc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713379602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KDTU3FzjibRUJKPEWMCCyywhuLLud5bVopOBg0gKWU8=; b=Cf02gFRyQ8k0IW+Ed00T1XglECrEHESrVgPcTVvqZkSWNyVDMiAkO2C8ICeiGK8Bssgrfy +cYhqf20o0OuWLsJI/MFA8bO2uoiQwVUX6eiMNH56ywQwe+pky13wJ4bHEX53g4kgoasdk 0CWam3N9jz73w9Z4bAFLcBthTeR4Abo= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-167-ll4kZ09NMGSh9IwTjjdYvg-1; Wed, 17 Apr 2024 14:46:41 -0400 X-MC-Unique: ll4kZ09NMGSh9IwTjjdYvg-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-5d8bcf739e5so5692282a12.1 for ; Wed, 17 Apr 2024 11:46:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713379600; x=1713984400; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KDTU3FzjibRUJKPEWMCCyywhuLLud5bVopOBg0gKWU8=; b=oGjHpodrVecJRdG1QH+0/deyCWvrEE+8yzE6ufb6+RCzhw/bNssEywpQuK4ImADbJV MDL/xvYYYit/xK3QOXPJSX8VC8HEeJN0HOnOdNHmc3yfShNYWFAVg5sv75t+LIO6vHD+ OxtKWo302+UZ4rwEh0tYTVxTzHKuq+qLFby+zp4vscLigC8WEMKXo9k/LrfwAoF3zbIt F0SYN0R0aNG4H44DDu2DhtFZ52wEHi5JJysDT4WgyMDJ/exoCVYj2MJdchgZXU+IL2yO 7MK3gU7d8jFHG4NBzDf75YEJmGEDfLxAv/g9yKSRQhP5SMREFzgQ5qsYnuGaBqymMsUg 0S7w== X-Gm-Message-State: AOJu0YwwsLW8FbpC6dzqQKtZ7XFkh9f1F92/Wt9FLqz6uCfsJ8/1dLak ht+54WkjwOqfhdCmSJEz84ZJfqRUW9n/I2ysdhmSzrmuCA56ei3lJJh5mntHZ89+yJVl0C0sdM7 GIdoYGuedlT4OEH8+ALy/s/HtGk/4t9hwKSNOYRdZNnM3z8nKWOwwafAwIItxIv5ILVqto2SmHN xdK/9bWxDHvKh9gcoN0eYTpme7mvJDEM/4jpwN X-Received: by 2002:a17:90a:9909:b0:2a7:600e:ce0 with SMTP id b9-20020a17090a990900b002a7600e0ce0mr233168pjp.42.1713379600145; Wed, 17 Apr 2024 11:46:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEefrKjf8hR6vysev8N1U3Af7P0FcMZWNFywX2QTVCGYw2BaKSpSnLyGgInG9SZY9kBK0bXRiIeN/xG2JA36Tk= X-Received: by 2002:a17:90a:9909:b0:2a7:600e:ce0 with SMTP id b9-20020a17090a990900b002a7600e0ce0mr233156pjp.42.1713379599836; Wed, 17 Apr 2024 11:46:39 -0700 (PDT) MIME-Version: 1.0 References: <20240326235249.399418-1-amerey@redhat.com> <20240327140648.GD9427@gnu.wildebeest.org> In-Reply-To: From: Aaron Merey Date: Wed, 17 Apr 2024 14:46:28 -0400 Message-ID: Subject: Re: [PATCH] config/profile.fish.in: Prevent bracketed variables and unmatched wildcard errors To: Mark Wielaard Cc: elfutils-devel@sourceware.org, =?UTF-8?B?RnJlZGVyaWsg4oCcRnJlc2/igJ0gUy4gT2xlc2Vu?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 27, 2024 at 10:06=E2=80=AFAM Mark Wielaard wro= te: > > Not knowing fish this looks OK to me. We might want a testcase like > the one that was just added for config/profile.sh to make sure we ship > something that runs correctly. Could be something as simple as: > > type fish 2>/dev/null || (echo "no fish installed"; exit 77) > fish ${abs_top_builddir}/config/profile.fish On Sat, Mar 30, 2024 at 7:32=E2=80=AFAM Frederik =E2=80=9CFreso=E2=80=9D S.= Olesen wrote: > > On Wed, Mar 27, 2024 at 03:06:48PM +0100, Mark Wielaard wrote: > > Adding Freso to the CC since he is the original author of the fish > > support. > > Looks good to me! I don=E2=80=99t want to claim any specific authorship > or special knowledge of it. I basically just adapted the existing > bash/.sh profile script for local use and then retrofitted that > for upstream submission. I=E2=80=99m happy that other fish users are > contributing to improving it! :) Thanks, pushed as commit eeea53b41b12dc9633ce6a3b1eb5c7d0ba0e057f with Mark's testcase added. Aaron