From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 201763857B99 for ; Thu, 7 Jul 2022 16:40:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 201763857B99 Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-211-EJGXwSoDOQGlzBv3K23yoQ-1; Thu, 07 Jul 2022 12:40:17 -0400 X-MC-Unique: EJGXwSoDOQGlzBv3K23yoQ-1 Received: by mail-qk1-f197.google.com with SMTP id l189-20020a37bbc6000000b006af2596c5e8so18410091qkf.14 for ; Thu, 07 Jul 2022 09:40:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nvFYP+bR8kQx8FhS6JFha8mgVWQOyXwurBZK1vUzNMw=; b=W203NdPsH1Bl94c59VPsJnOImAx98q6te2002SNiU9i3ZJcL2lrAcoirQo3uk1f92X 6b6vkbeU1cXq9HHnXBjYQ/tbyoapIB+ypRrL+BIyg+C/6xP1LsuRitSDcv12DC06UDQ5 NHTNrlSLWix4AAD/wN3Ob5ReHBkLT6yxOwIqRRaxqjI0rP23tiGlS+HmGGnPYOap07+/ r7y4ce/XKgwLUjzvco3jGABYV4+YlcXGaBvoFHwpuAI8+DBtRWnYmQVgN3ORxOMXHijQ vJ/H57TGYScIGJslfZ4ucN24Qy5Mdxd7nwA3ST+Mn1Db3nYUUuKj4ZKwJp1FFAbDeowF 2a2Q== X-Gm-Message-State: AJIora8PQw94yfGQgg6+37N4StFy/WkDb1HP0NsQy2w1GFjGqgavdg28 ouWuYj/rCU7cZ6tbC8f0NvtihvpTySU/0U80fwMLE1gMrtFSoJq7JL6K6mVT1rwsrNsPkFEihAO U8krygnjSWofut8DgvOILILsFnOiV0hdcP7LpXt+3 X-Received: by 2002:a05:620a:45a4:b0:6b2:65fa:cb10 with SMTP id bp36-20020a05620a45a400b006b265facb10mr22819158qkb.232.1657212016703; Thu, 07 Jul 2022 09:40:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1saNtqNr3nCEBhZrlF+nNk1cj9P/A0U81NOwjnKu/j6LmJt36wf5oM9oOY+Liin/80cyiE9tyTsauL05axDKqo= X-Received: by 2002:a05:620a:45a4:b0:6b2:65fa:cb10 with SMTP id bp36-20020a05620a45a400b006b265facb10mr22819147qkb.232.1657212016475; Thu, 07 Jul 2022 09:40:16 -0700 (PDT) MIME-Version: 1.0 References: <3003776.hSsdSGGBHf@milian-workstation> In-Reply-To: <3003776.hSsdSGGBHf@milian-workstation> From: Aaron Merey Date: Thu, 7 Jul 2022 12:40:05 -0400 Message-ID: Subject: Re: [PATCH] Introduce public dwfl_get_debuginfod_client API To: Milian Wolff Cc: elfutils-devel@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 16:40:21 -0000 Hi Milian, On Thu, Jul 7, 2022 at 10:47 AM Milian Wolff wrote: > > Dwfl can use debuginfod internally, which was so far totally opaque > to the outside. While the functionality is great for users of the > dwfl API, the long wait times induced by downloading of data over > debuginfod lead to complaints by endusers. To offer them a bit more > insight into the internal ongoings, one can now use e.g. > `debuginfod_set_progressfn` on the handle returned by > `dwfl_get_debuginfod_client` to report download progress. > > Rename get_client to dwfl_get_debuginfod_client and make it public. > Unconditionally compile debuginfod-client.c and stub the new public > function and always return NULL when debuginfod integration was > disabled. Thanks for the patch. This looks ok and I was able to successfully run the testsuite with and without debuginfod enabled. > @@ -70,7 +70,7 @@ libdwfl_a_SOURCES = dwfl_begin.c dwfl_end.c dwfl_error.c > dwfl_version.c \ Some line breaks may have accidentally snuck into the patch. I had to manually remove the line break right after "dwfl_error.c" for git to apply the patch without error. > +/* Return the internal debuginfod-client connection handle for the DWFL > session. > + When the client connection has not yet been initialized, it will be done > on the > + first call to this function. If elfutils is compiled without support for > debuginfod, Same goes for these line breaks. Aaron