From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 46BD43858D1E for ; Tue, 21 Feb 2023 02:29:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 46BD43858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x130.google.com with SMTP id m6so3961664lfq.5 for ; Mon, 20 Feb 2023 18:29:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Cj/5hl1cmGgM3Jk9pEhC3zG9o89F3E7NMzI9CTk4VyI=; b=p/Gdw0dpdT2mhanHrwp/N8ypt2wocQ0L1i5W9qJPQ26sm83P4h9xVY4tyKmy/PIj0p tLaoB7uwo0nCyzzzANwmn/jSi2mGw5TpsfF1Z4Tb20u1TondyV6dXvSLYOuDokAQAmyz DyKIvDWHand9dS72TVeK3YtP1Joa83S0LEAjofY2JUnqAJiHVKIM1t1vzLvuLgJHWGDx LP9YZ8pkYuqQ4JbhArHD0u2oWti4jodGN0WxtObxrsyZsOS7mXAEY2mlAaUSZPHBv+2E 3EWMUYMC4Rr1fhnxcwmxWH0o51gkDa3+VgmfzX7mAJop3/qaljLWKZTeNe9YIxg3dy+e 2O0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cj/5hl1cmGgM3Jk9pEhC3zG9o89F3E7NMzI9CTk4VyI=; b=jpv/wHWY1Kl4L0jLH8MWpc3xF4y9HignTCzpqnRYh6draqLpBUrySb9NzJxys6dy5s mG9TMkzX2VgGMFiEC61cRW4T3lzTmiV8Jh8fZnIJol9x0R1OFq9TMPJTq6Dfpz/vNChG TD+EuW9M7v+Ojcx/p60agcCnyKlqr8eiatReEti3ctnl3eqkprNdv8g12hKyzH8lAVyy UkHlAnR1ZRsPaHWZDSiKZQIIOLguqoPjMqCARAEBf5532xIzkKERX8Y+OWRi1jKLCdwY mHm9T65kF+S/0iMHcAJoHHbCcK/zUcGJHNKWkvljSopHmio6xf5AkiQkd7RJJkVpHyYQ Sxqw== X-Gm-Message-State: AO0yUKViEadD7s9tmgp68jqDiDKbjOE/dAdM47glpuQiC6Ohcmp1jr51 ciULclcVZu4ixAb0BRPgUJLR02E1W7Ws3CNVjZw= X-Google-Smtp-Source: AK7set/q/5Qp1aKCJsJnwzEp3jzBEA1DXpPSxvPjzqXL/CsGK2pfsNq7PrkBLuH6X4llVb7PqPIDHZKNwqnkLTVeKyU= X-Received: by 2002:ac2:518c:0:b0:4db:2c9f:1a23 with SMTP id u12-20020ac2518c000000b004db2c9f1a23mr1233575lfi.6.1676946540459; Mon, 20 Feb 2023 18:29:00 -0800 (PST) MIME-Version: 1.0 References: <20230220155518.86598-1-mark@klomp.org> <20230220155518.86598-3-mark@klomp.org> In-Reply-To: From: Evgeny Vereshchagin Date: Tue, 21 Feb 2023 05:28:48 +0300 Message-ID: Subject: Re: [PATCH 2/2] libdw: Use elf_rawdata when checking .debug section To: Aleksei Vetrov Cc: Mark Wielaard , elfutils-devel@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Mon, 20 Feb 2023 at 19:03, Aleksei Vetrov wrote: > On Mon, Feb 20, 2023 at 3:55=E2=80=AFPM Mark Wielaard wr= ote: > > > > .debug sections are raw bytes and don't need conversion even when host > > and file have different endian order. > > Thank you! I like this patch more for its simplicity, looks good to me. Agreed. I haven't actually tested the patch though but since it's covered by the fuzz target it should be tested once it's merged anyway. On a somewhat related looking at some recent patches and especially https://sourceware.org/git/?p=3Delfutils.git;a=3Dcommit;h=3D64ee2cb792e7b6b= a6ad2a5759bff7ce8714e4668 it seems apart from OSS-Fuzz elfutils is fuzzed elsewhere. Aleksei I wonder if it would be possible to add those fuzz targets to OSS-Fuzz? There are blind spots there and I think it would be really great to start covering at least some of them. Thanks, Evgeny Vereshchagin