From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57125 invoked by alias); 12 Dec 2017 14:51:59 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 57097 invoked by uid 89); 12 Dec 2017 14:51:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*mark X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mail-oi0-f66.google.com Received: from mail-oi0-f66.google.com (HELO mail-oi0-f66.google.com) (209.85.218.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Dec 2017 14:51:56 +0000 Received: by mail-oi0-f66.google.com with SMTP id t81so14140448oih.13 for ; Tue, 12 Dec 2017 06:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5kzRWJfhXoWunEAAt5Uf9XYUJpZ3yrRsqVhp7rol0x0=; b=gSe+wEnGpN2mQkv7CgKod+sNweXMO11iufjUrDT144RanSx3JwUiVVoOffTVKITG+z 5MMUctgcXplMzY2fX9hXqdeBHvzCBthDMjoxhvwZEbayVA1BfUMt2n704I/ZwRDv49Ww EcZXCimJdFeXX/zNNl2uMfO44Xzq8oGFp2gNEl0bJEIG5cAO9jz57pDuRhLckmlDS0X3 pMRhsPZMq+9+cyXWRVWfDygj1Pz5W6lcPJCRDu064QXAMMFxHoy7BaS/PTeLsc3SRxjX VxWHWSXOurSdx9pWglSt4kuz1RiptL+7oxeMQimtT4aslSbEtkDgSTZi4u/qPa34Ypay iWSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5kzRWJfhXoWunEAAt5Uf9XYUJpZ3yrRsqVhp7rol0x0=; b=KcRTrUgPR79BA73VXI1ft2RVMh5wzfpbLGZtblnXnakPeUwmB+0BvME8/jHllB04v0 Wt+BdWw1LFdgRLm2XtJMKZCAY2T3fu2ca0Ff7LsXlkkZwpfwfx+0TKDxQBiHJsFZZy/h jKrBLSyQe+jLl3udaqgpFQ0RNLLdzkaBirqufq+lM13QmwMZ158W629KLyvMxFBZBKOd LiaRB1rApu87zBViFaDvIAaXSIJyE/Trnvw66uEGLjqMj+gQlvlEzuwQN7P4D+px9Zgc NEOLykgL5yEiXhfVxW/5agP1MV9Uu9NeMw8rWQiuegDdqe8vOBzmJsHPy27LK5gOsbpn f5uQ== X-Gm-Message-State: AKGB3mKh+MNYi9cbsfkcr4LITVuqhMY36Tn1aQXl4z1H4NtwNfYJaCfw ai6zxcV8ZqWx5ObVcrUH8526Zma/TO4sUaghCv0= X-Google-Smtp-Source: ACJfBosZFtsUKj1460D1bh1+OMffnzQiN7ryyqnh+BSR3SHy/V1kwvJFBiswpZAe/359dfRWd83kGrRi6ZpbgPhirZY= X-Received: by 10.202.236.135 with SMTP id k129mr3219899oih.57.1513090315058; Tue, 12 Dec 2017 06:51:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.168.71.194 with HTTP; Tue, 12 Dec 2017 06:51:34 -0800 (PST) In-Reply-To: <1513033994.15696.50.camel@klomp.org> References: <20171208061738.25974-1-namhyung@gmail.com> <1513033994.15696.50.camel@klomp.org> From: Namhyung Kim Date: Tue, 12 Dec 2017 14:51:00 -0000 Message-ID: Subject: Re: [PATCH] config: Add pkgincludedir to Cflags To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-q4/txt/msg00108.txt.bz2 Hello, On Tue, Dec 12, 2017 at 8:13 AM, Mark Wielaard wrote: > On Fri, 2017-12-08 at 15:17 +0900, Namhyung Kim wrote: >> The libelf and libdw uses pkginclude_HEADERS but the pkg-config file >> misses to have it the Cflags. This was a problem for libdw users since >> it gave nothing to include, but one needs to add /usr/include/elfutils >> directory to use the libdw.h header file. > > I this really an issue? > > libelf has two public headers which are placed in the includedir and so > should be simply included as #include and #include . > > libdw does indeed put its headers in includdir/elfutils, but as far as > I know everybody includes them using that subdir, so #include > and #include , etc. > > Wouldn't this change how people include the headers? > Do we want to change it? Oh, I wasn't aware of the (preferred) way of including libdw headers. Will change my code to use that pattern. Sorry for the noise. Thanks, Namhyung