From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) by sourceware.org (Postfix) with ESMTPS id 947C13858C2F for ; Tue, 12 Dec 2023 17:16:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 947C13858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 947C13858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702401409; cv=none; b=Tax+lXsn3YqBp3t9A+A6yRUDzSVR4WezxDTBG/5Lherel6UJpL8+jKhfMbRMHcN41TlLo6PBGtVujZSnhOzg1iVCjooky3fWr1sLoyZCXH858SsKfiHSo8bAvLbWZvai+e5hjbOXdKQwt/SGdC/qszV6GCSmK3QWmmbniNZejkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702401409; c=relaxed/simple; bh=KyGyM9caxm7zF2spKKY8Q88yfrba0qFieAYFXfym2Pg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=pqEfVG1i+rTTZr+RlrRJ3f91A/O28Z6smBGG+DtvSpoNe/SBrsS52XvVtifgRRxC8OiRgRzQNWiatTNcrkaNuXPjhuxrw7qyulcL4MHaz/0fG7lMv0baJM6/qn9wsWcq935QOWdYUgiKz1T6Fe/N6wNgdUI5BUKhBJVTwQjn0t8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-1fab887fab8so4407474fac.0 for ; Tue, 12 Dec 2023 09:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702401408; x=1703006208; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KyGyM9caxm7zF2spKKY8Q88yfrba0qFieAYFXfym2Pg=; b=T3J4aJuWJr0fCkPp7QoVHt/pCNXJ/idZ125iSy2nG1KCjJv07jWqooV673SzL+CaIR vdUthIKOGyzSuRlropzJDaDDuG8Os3bPpuHwaP5HwmhoqkdPgq8cdk9Z6x6I21Jijg7a X1dqkWUw74i4CyzI0N6d75JYvWedw3MzwH7EJLCgJxYm0Ft5FGNmJQqOhbI9IsXK4Oz4 R+a5lxBNEsni8YpdQpytTbYo7TuBNMu3lfwTHm/+SY4cs3DlGVCgJZQGVwXS8HbZcBZb vUQ+BlviE24QTWY5wjTTcEhBG+KgsdzivNoPHQB4cwt4IKwoY1um9SSEvDbEWQGN5pU6 cLaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702401408; x=1703006208; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KyGyM9caxm7zF2spKKY8Q88yfrba0qFieAYFXfym2Pg=; b=a+O4wG/cHLGnAzM7u62/is63qA5Mkx9xu7iji1WSe/79TzlgV/K9O8ufqypoMa8Fl6 mltpsfGEG/gxqJ5/h6ltEBfTMH3Ii3o4EEWl5VqVdriNPLoO+/NjPikXhBrFyWeSQht5 k+KGfKqvZfrXLKDz4JPbHfSco8yYidceDKPa5Br5KMzNnTjWPokvN8JUeAP9ttl75eXm K+UkzEEuxCPrG4hGb0yP/V863HHNoSGiboj/uZOsZsSoRxyoT881j0uZPj/BZobILllC EUJq1cYIa6upC+jSPDhR+0pathOZ9Ecz3awPh7KO+c+ezxlysK1azkrnfVwJjvnM0Hal h6Lg== X-Gm-Message-State: AOJu0YxcV01/aVn2CiKbGYRe7+h1OY0ImC4NpDdQuZhySyZXghBDXz9v gUckr1pPfBinydZKt0CaRm+Ky9BrSGuPc1bQpAjheo4u X-Google-Smtp-Source: AGHT+IHDlZ79d/zMaWxZ28+9Y59A96qKrjBAAjX6bqCBgIEw5UTyCEtssd/l4egE0RlEg/BfC3wgcB+83u1z9eGF/Ns= X-Received: by 2002:a05:6870:1594:b0:1fb:30b7:95 with SMTP id j20-20020a056870159400b001fb30b70095mr7736352oab.20.1702401407914; Tue, 12 Dec 2023 09:16:47 -0800 (PST) MIME-Version: 1.0 References: <20231210202033.151578-1-raj.khem@gmail.com> In-Reply-To: From: Khem Raj Date: Tue, 12 Dec 2023 09:16:22 -0800 Message-ID: Subject: Re: [PATCH] Add helper function for basename To: Mark Wielaard Cc: elfutils-devel@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 12, 2023 at 5:18=E2=80=AFAM Mark Wielaard wrot= e: > > Hi Khem, > > On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote: > > musl does not provide GNU version of basename and lately have removed > > the definiton from string.h [1] which exposes this problem. It can be > > made to work by providing a local implementation of basename which > > implements the GNU basename behavior, this makes it work across C > > libraries which have POSIX implementation only. > > Thanks, this should work, but wouldn't it be easier to add a configure > test for having basename defined in string.h and then only define > basename in libeu.h (and build basename.c) if it isn't. So that all the > code can just keep using basename (we just have to make sure libeu.h is > included)? we could do that but it will not work as expected with older musl releases where the prototype in string.h will exist. > > Cheers, > > Mark