From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by sourceware.org (Postfix) with ESMTPS id 1B6753858C39 for ; Thu, 9 Dec 2021 09:52:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1B6753858C39 Received: by mail-ua1-x92e.google.com with SMTP id l24so9721065uak.2 for ; Thu, 09 Dec 2021 01:52:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0a+i77rqli6bY7zoBBhLzKbitSnFTDW3/zKx7MqU/x8=; b=z/bo6gM5A96xmwFS6XZv581+ai4hCsnsaODrFGsAdmyREtck7wO1vJYPlrx5ie+swv C1KfG9vSi8p4r7H4AjnUcMcpMOMdL6gcSmEpSQOFE16/1AhRMuRw57+PSa3NUwsuOMQY D146jbuR4T0o6vJkl4dRU0vOk8cuDz9+s2lJWwTXd1/G95Xde1f3BqpU1GhXlCZNxMi1 QbfCLhzulhLmeXG3YNMm+7Zk4nGQ5dtMnlOxpMLPR7zLZt6N/ez9sqUXqkht55vNzorJ vZ5A7WB5uCSmEfShsaQb0D9UXhzwQ86UbS0GcaqNtpSomOhr9gFK+ZcREevNzYBGC/JG +jxA== X-Gm-Message-State: AOAM532daZGq3DSSobY1MJbSqVRsb7/i8Zzp6IpO6E4zPMULI+6ss6OS VycAKMH9Evg7vMYoNEbbIIcH5sF8Ca7hKESNJ1Y= X-Google-Smtp-Source: ABdhPJyRE5CPwhlYmUzlNICH20zVqbZfv5a22dOSkUIXN4PBq35ZoRoaxGkCeNirhbegxeF7e8uvEKw3N8477n8Q1K0= X-Received: by 2002:a05:6102:38d4:: with SMTP id k20mr6030460vst.42.1639043578739; Thu, 09 Dec 2021 01:52:58 -0800 (PST) MIME-Version: 1.0 References: <20211121221411.404194-1-alex@linutronix.de> In-Reply-To: From: Alexander Kanavin Date: Thu, 9 Dec 2021 10:52:47 +0100 Message-ID: Subject: Re: [PATCH] debuginfod/debuginfod-client.c: correct string format on 32bit arches with 64bit time_t To: Mark Wielaard Cc: elfutils-devel@sourceware.org, Khem Raj X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 09:53:00 -0000 Alright, I just sent a patch that replaces time_t with long instead. I tested it on x86, x86-x32, x86-64. Alex On Wed, 8 Dec 2021 at 16:31, Mark Wielaard wrote: > Hi Alexander, > > On Sun, 2021-12-05 at 21:45 +0100, Alexander Kanavin wrote: > > I'm not sure; the point of this patch is simply to ensure debuginfod > builds > > everywhere without errors. Making the types consistent is perhaps better > > done as a followup? > > I think the issue of the code not compiling in some environments is > because of the inconsistent use of types. So I rather fix the build > errors by fixing the used types than to simply cast the errors away. > > Cheers, > > Mark >