From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 7F48F385842C for ; Mon, 23 Aug 2021 15:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F48F385842C Received: by mail-ej1-x62a.google.com with SMTP id u3so37866301ejz.1 for ; Mon, 23 Aug 2021 08:23:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pzRRcTzGu/X1LZXmR+hDk3CTY4PyEggPhRIlWURduzY=; b=ZSGPs5ttBem1mGBQ2LnHLTTFZwcgDXQ14Lkver2hbgYxapo+6/XV6c0NoJ+3sEHK9b AadBEj75CUPqCzHud1+4yFgmAc0l+CPgWELLS2JTwe7dQ0En+9svJmzCnLiCEPFtYbsU CEpaeYWT1fvyK6sAF4CGp/65Ey4fn6RZk37000H8W6QvrSUp73mlWZRc5x4qL0Pptwp5 yjOR0gAK6luaLCNSiV5fhm8V9LUfYkL+bBbFvTS/VU1hHqmPK6vB8SMD9YfK2C7XaPQR VwGF70eoDoQnDFB/yhfbpU7JBtvuXE4I+BiDYEGrF3uQ6SvqimSsgiaNhPP8cCUFU9c2 /a6g== X-Gm-Message-State: AOAM5308mwE86CmjC8SIV5y+EXTeUFzRjzTg+4+Z9aPbUAxiuJqGVECk k+3S3N2ibta7zYo6eDvL/OnozujSODE2lSsrz1seRw== X-Google-Smtp-Source: ABdhPJyGAnEE/xQqDRArK8p52Gh+u0hslg1TUWzVVgOOaT+Zm/N0roXnyqFJ7eLE1v80WxUMWH+y7OjhvU+Fs2OQS1g= X-Received: by 2002:a17:906:445:: with SMTP id e5mr36574717eja.497.1629732198137; Mon, 23 Aug 2021 08:23:18 -0700 (PDT) MIME-Version: 1.0 References: <20210820182008.2841402-1-abdulras@google.com> In-Reply-To: From: Saleem Abdulrasool Date: Mon, 23 Aug 2021 08:23:08 -0700 Message-ID: Subject: Re: [PATCH] lib: remove usage of `sys/cdefs.h` To: =?UTF-8?Q?=C3=89rico_Nogueira?= Cc: elfutils-devel@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-27.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2021 15:23:20 -0000 Hi =C3=89rico, Yes, it seems that `STROF` can be removed as well. However, I'd prefer to do that in a separate change. This way the change is a separate clean up rather than just happens to come along with the sys/cdefs.h removal. On Mon, Aug 23, 2021 at 5:48 AM =C3=89rico Nogueira w= rote: > > On Fri Aug 20, 2021 at 3:20 PM -03, Saleem Abdulrasool via Elfutils-devel= wrote: > > This header is a BSD header that is also available in glibc. However, > > this is a not a standard C header and was used for `__CONCAT`. Because > > this is not a standard header, not all libc implementations provide the > > header. Remove the usage of the header and always use the previously > > fallback path. This is needed in order to build with musl. > > On Void we provide our own file, since way too many > packages require them. Explains why I missed this :) > > > > > Signed-off-by: Saleem Abdulrasool > > --- > > lib/fixedsizehash.h | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/lib/fixedsizehash.h b/lib/fixedsizehash.h > > index dac2a5f5..f333ad99 100644 > > --- a/lib/fixedsizehash.h > > +++ b/lib/fixedsizehash.h > > @@ -30,17 +30,12 @@ > > #include > > #include > > #include > > -#include > > > > #include > > > > -#ifdef __CONCAT > > -#define CONCAT(t1,t2) __CONCAT (t1,t2) > > -#else > > #define STROF(t2) t2 > > #define CONCAT_EXPANDED(t1,t2) t1 ## t2 > > #define CONCAT(t1,t2) CONCAT_EXPANDED(t1,t2) > > -#endif > > I think you can remove STROF from here too, can't you? I don't see it > being used anywhere. > > > > > /* Before including this file the following macros must be defined: > > > > -- > > 2.33.0.rc2.250.ged5fa647cd-goog >