From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) by sourceware.org (Postfix) with ESMTPS id 5FD213858025 for ; Wed, 26 May 2021 15:48:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5FD213858025 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A9FE4529A5; Wed, 26 May 2021 17:48:45 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EctKIzPshqXd; Wed, 26 May 2021 17:48:44 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 To: "Petr Ovtchenkov" Cc: Subject: Re: [PATCH 1/1] support cross compilation From: =?utf-8?q?=C3=89rico_Nogueira?= Date: Wed, 26 May 2021 12:41:51 -0300 Message-Id: In-Reply-To: <20210526135850.1b967be8@void-ptr.info> X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2021 15:48:49 -0000 On Wed May 26, 2021 at 10:58 AM -03, Petr Ovtchenkov wrote: > On Wed, 26 May 2021 10:09:31 -0300 > =C3=89rico Nogueira wrote: > > > Hi! Are you sure this is necessary? In Void Linux, we cross compile > > elfutils for arm and aarch64 without any issue, and I have built it a > > few times for powerpc as well. > >=20 > > Hello! > > Yes, I am sure. I do not know about you process (check, that you really > cross, not run via qemu or like). Build process _run_ i386_gendis to > generate headers: Yes, we really cross. > > > if MAINTAINER_MODE > noinst_HEADERS +=3D memory-access.h i386_parse.h i386_data.h > > noinst_PROGRAMS =3D i386_gendis$(EXEEXT) > > $(srcdir)/%_dis.h: %_defs i386_gendis$(EXEEXT) > $(AM_V_GEN)./i386_gendis$(EXEEXT) $< > $@T <=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > $(AM_V_at)mv -f $@T $@ > > else > > $(srcdir)/%_dis.h: > @echo '*** missing $@; configure with --enable-maintainer-mode' > @false > > endif > We always use the release tarballs, which already have the %_dis.h files. This explains why we haven't hit any issues. > > > > +if CROSS > > > +i386_gendis_LINK =3D ${CC_FOR_BUILD} ${LDFLAGS} -o $@ > > > + > > > +$(i386_gendis_OBJECTS): CC=3D${CC_FOR_BUILD} > > > +endif =20 > > > > Isn't this hardcoding an assumption that the build machine is x86? > > I think no. But this question is for original author: Indeed it isn't, I hadn't looked into it properly yet. > > commit 3cbdd387c752999255aea91600b5cfdefbeac7d0 > Author: Ulrich Drepper > Date: Wed Jan 2 17:44:39 2008 +0000 > > propagate from branch 'com.redhat.elfutils.disasm' (head > d15b4eb794e81e477f9896fe82a74cb5ecf4514c) to branch > 'com.redhat.elfutils' (head > eaacbf01f8cc89d043ec6eca9b5e35cb5c4cde06) > > ;) Anyway, couldn't you (re)use the distribution tarball generation stuff for cross setups from git master? Otherwise this would add a dependency on autoconf-archive for anyone generating the configure script locally... I think a final version of this patch should document the autoconf-archive requirement, if it's merged. Cheers, =C3=89rico