From: "Érico Nogueira" <ericonr@disroot.org>
To: "Omar Sandoval" <osandov@osandov.com>, <elfutils-devel@sourceware.org>
Subject: Re: [PATCH] libdwfl: fix crash when reading link map
Date: Wed, 09 Jun 2021 21:59:06 -0300 [thread overview]
Message-ID: <CBZJ4KLN08BH.3PCT1OMT09CLN@mussels> (raw)
In-Reply-To: <YMFh9YSu2n4u3Q9i@relinquished.localdomain>
Hope you don't mind my nit, then :)
On Wed Jun 9, 2021 at 9:51 PM -03, Omar Sandoval wrote:
> On Wed, Jun 09, 2021 at 05:45:57PM -0700, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> >
> > When read_addrs() was converted was converted from a nested function to
^^^^^^^^^^^^^ repeated words
> > a normal function, there was a mistake in converting "buffer" from a
> > closure variable to a parameter: we are checking whether the pointer
> > argument is NULL, not whether the buffer itself is NULL. This causes a
> > NULL pointer dereference when we try to use the NULL buffer later.
> >
> > Fixes: 3bf41d458fb6 ("link_map: Pull read_addrs() into file scope") made
> ^^^^
> Stray word here, hopefully not too much trouble to fix up when applying.
next prev parent reply other threads:[~2021-06-10 1:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 0:45 Omar Sandoval
2021-06-10 0:51 ` Omar Sandoval
2021-06-10 0:59 ` Érico Nogueira [this message]
2021-06-10 1:02 ` Omar Sandoval
2021-06-10 10:44 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBZJ4KLN08BH.3PCT1OMT09CLN@mussels \
--to=ericonr@disroot.org \
--cc=elfutils-devel@sourceware.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).