From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) by sourceware.org (Postfix) with ESMTPS id 57B493858417 for ; Mon, 23 Aug 2021 12:48:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 57B493858417 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 52B1F637BF; Mon, 23 Aug 2021 14:48:37 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q93pmiclsUod; Mon, 23 Aug 2021 14:48:36 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH] lib: remove usage of `sys/cdefs.h` From: =?utf-8?q?=C3=89rico_Nogueira?= To: "Saleem Abdulrasool" , Date: Mon, 23 Aug 2021 09:42:43 -0300 Message-Id: In-Reply-To: <20210820182008.2841402-1-abdulras@google.com> X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2021 12:48:50 -0000 On Fri Aug 20, 2021 at 3:20 PM -03, Saleem Abdulrasool via Elfutils-devel w= rote: > This header is a BSD header that is also available in glibc. However, > this is a not a standard C header and was used for `__CONCAT`. Because > this is not a standard header, not all libc implementations provide the > header. Remove the usage of the header and always use the previously > fallback path. This is needed in order to build with musl. On Void we provide our own file, since way too many packages require them. Explains why I missed this :) > > Signed-off-by: Saleem Abdulrasool > --- > lib/fixedsizehash.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/lib/fixedsizehash.h b/lib/fixedsizehash.h > index dac2a5f5..f333ad99 100644 > --- a/lib/fixedsizehash.h > +++ b/lib/fixedsizehash.h > @@ -30,17 +30,12 @@ > #include > #include > #include > -#include > =20 > #include > =20 > -#ifdef __CONCAT > -#define CONCAT(t1,t2) __CONCAT (t1,t2) > -#else > #define STROF(t2) t2 > #define CONCAT_EXPANDED(t1,t2) t1 ## t2 > #define CONCAT(t1,t2) CONCAT_EXPANDED(t1,t2) > -#endif I think you can remove STROF from here too, can't you? I don't see it being used anywhere. > =20 > /* Before including this file the following macros must be defined: > =20 > -- > 2.33.0.rc2.250.ged5fa647cd-goog