From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 39D5738582B7 for ; Fri, 14 Oct 2022 20:35:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 39D5738582B7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x0e.wildebeest.org [172.31.17.144]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id B88A7301AB1E; Fri, 14 Oct 2022 22:35:04 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 0D8ED2E80253; Fri, 14 Oct 2022 22:35:04 +0200 (CEST) Date: Fri, 14 Oct 2022 22:35:03 +0200 From: Mark Wielaard To: Yonggang Luo Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec' Message-ID: References: <20220920084307.1696-1-luoyonggang@gmail.com> <20220920084307.1696-2-luoyonggang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920084307.1696-2-luoyonggang@gmail.com> X-Spam-Status: No, score=-3039.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Tue, Sep 20, 2022 at 04:43:01PM +0800, Yonggang Luo via Elfutils-devel wrote: > These filenames are invalid on win32 This looks ok to me, but I don't really know why these files were named this way in the first place. The files themselves are not directly used, they are there to recreate the hello3*rpm test files. Frank, would you mind if these are just renamed to normal *.spec? Thanks, Mark > Signed-off-by: Yonggang Luo > --- > tests/Makefile.am | 2 +- > tests/debuginfod-rpms/{hello2.spec. => hello2.spec} | 0 > tests/debuginfod-rpms/{hello3.spec. => hello3.spec} | 0 > 3 files changed, 1 insertion(+), 1 deletion(-) > rename tests/debuginfod-rpms/{hello2.spec. => hello2.spec} (100%) > rename tests/debuginfod-rpms/{hello3.spec. => hello3.spec} (100%) > > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 85514898..fc2235f4 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -563,7 +563,7 @@ EXTRA_DIST = run-arextract.sh run-arsymtest.sh run-ar.sh \ > debuginfod-rpms/fedora31/hello3-debugsource-1.0-2.x86_64.rpm \ > debuginfod-rpms/fedora31/hello3-two-1.0-2.x86_64.rpm \ > debuginfod-rpms/fedora31/hello3-two-debuginfo-1.0-2.x86_64.rpm \ > - debuginfod-rpms/hello2.spec. \ > + debuginfod-rpms/hello2.spec \ > debuginfod-rpms/rhel6/hello2-1.0-2.i686.rpm \ > debuginfod-rpms/rhel6/hello2-1.0-2.src.rpm \ > debuginfod-rpms/rhel6/hello2-debuginfo-1.0-2.i686.rpm \ > diff --git a/tests/debuginfod-rpms/hello2.spec. b/tests/debuginfod-rpms/hello2.spec > similarity index 100% > rename from tests/debuginfod-rpms/hello2.spec. > rename to tests/debuginfod-rpms/hello2.spec > diff --git a/tests/debuginfod-rpms/hello3.spec. b/tests/debuginfod-rpms/hello3.spec > similarity index 100% > rename from tests/debuginfod-rpms/hello3.spec. > rename to tests/debuginfod-rpms/hello3.spec > -- > 2.36.1.windows.1 >