From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id D192C3858403 for ; Sun, 16 Oct 2022 15:19:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D192C3858403 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x0e.wildebeest.org [172.31.17.144]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7E1973000913; Sun, 16 Oct 2022 17:19:12 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 58D5F2E8028B; Sun, 16 Oct 2022 17:19:12 +0200 (CEST) Date: Sun, 16 Oct 2022 17:19:12 +0200 From: Mark Wielaard To: vvvvvv@google.com Cc: elfutils-devel@sourceware.org, kernel-team@android.com Subject: Re: [PATCH] libdwfl: add dwfl_report_offline_memory Message-ID: References: <20220920133637.2639873-1-vvvvvv@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920133637.2639873-1-vvvvvv@google.com> X-Spam-Status: No, score=-3033.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Aleksei, On Tue, Sep 20, 2022 at 01:36:37PM +0000, Aleksei Vetrov via Elfutils-devel wrote: > This method allows to read and report ELF from memory instead of opening > a file. That way arbitrary memory can be worked with, e.g. when coming > from a stream without the need to persist. > > Another useful application is for fuzzing, because fuzzers might be able > to track accesses to the memory and change the fuzzer input to cover > more edge cases through more targeted input. Hence, add a new function > along with a test case. This is a very nice patch. Pushed almost as is. While reviewing I added some ChangeLog entries. I added the NEWS entry. In libdw.map I moved dwfl_report_offline_memory under ELFUTILS_0.188. In the tests/Makefile.am I added libeu to dwfl_report_offline_memory_LDADD because the test uses error. Thanks, Mark