From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 523DC3858288 for ; Tue, 20 Dec 2022 21:35:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 523DC3858288 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id E0E3330006EE; Tue, 20 Dec 2022 22:35:53 +0100 (CET) Received: by reform (Postfix, from userid 1000) id 58E9B2E803AC; Tue, 20 Dec 2022 22:35:53 +0100 (CET) Date: Tue, 20 Dec 2022 22:35:53 +0100 From: Mark Wielaard To: "Guillermo E. Martinez" Cc: elfutils-devel@sourceware.org, "Jose E. Marchesi" , nickc@redhat.com Subject: Re: [PATCHv2] strip: keep .ctf section in stripped file Message-ID: References: <20220601155527.2192182-1-guillermo.e.martinez@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220601155527.2192182-1-guillermo.e.martinez@oracle.com> X-Spam-Status: No, score=-3032.4 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Guillermo, On Wed, Jun 01, 2022 at 10:55:27AM -0500, Guillermo E. Martinez via Elfutils-devel wrote: > This is the second version patch to avoid remove the CTF section in > stripped files. Changes from v1: > > - Add description in tests/run-strip-remove-keep-ctf.sh > mentioning how to regenerate test input file (testfile-ctf) > > Please let me know your thoughts. > > [...] > > CTF debug format was designed to be present in stripped files, so > this section should not be removed, so a new --remove-ctf option > is added to indicate explicitly that .ctf section will be stripped > out from binary file. Sorry, I see I never reviewed this v2 variant. I know we tried to coordinate with binutils so eu-strip and binutils strip would do the same thing. And that Jose had an idea for a new section flag to automatically detect what section should/shouldn't be stripped (into a separate .debug file). What was the conclusion of that? Thanks, Mark