From: Mark Wielaard <mark@klomp.org>
To: Timm Baeder <tbaeder@redhat.com>
Cc: "Tomasz Paweł Gajc" <tpgxyz@gmail.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] readelf: allow build with LLVM/clang
Date: Thu, 15 Jul 2021 14:10:20 +0200 [thread overview]
Message-ID: <YPAlrKpuGr5Nd4xD@wildebeest.org> (raw)
In-Reply-To: <37614938-c55e-32aa-78ba-1fb8b8969f32@redhat.com>
Hi Timm,
On Thu, Jul 15, 2021 at 07:46:15AM +0200, Timm Baeder via Elfutils-devel wrote:
> FWIW, there is a different version of this patch at
> https://sourceware.org/pipermail/elfutils-devel/2021q1/003674.html
> that doesn't have those problems as far as I remember.
Indeed, that looks more clean. I still like the nested function
approach better since it is more concise. But I added a ChangeLog
entry and pushed the above as:
commit 779c57ea864d104bad88455535df9b26336349fd
Author: Timm Bäder <tbaeder@redhat.com>
Date: Thu Mar 18 10:25:24 2021 +0100
readelf: Pull advance_pc() in file scope
Make advance_pc() a static function so we can get rid of another nested
function. Rename it to run_advance_pc() and use a local advance_pc()
macro to pass all the local variables. This is similar to what the
equivalent code in libdw/dwarf_getsrclines.c is doing.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Sorry I missed this patch earilier. If there are any other pending
patches that need review please ping them.
Cheers,
Mark
prev parent reply other threads:[~2021-07-15 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 9:59 Tomasz Paweł Gajc
2021-07-14 17:40 ` Mark Wielaard
2021-07-15 5:46 ` Timm Baeder
2021-07-15 12:10 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPAlrKpuGr5Nd4xD@wildebeest.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=tbaeder@redhat.com \
--cc=tpgxyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).