From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 02772385780A for ; Tue, 20 Jul 2021 19:08:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 02772385780A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x18.wildebeest.org [172.31.17.154]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id C2172300027E; Tue, 20 Jul 2021 21:08:35 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 4CDF32E804E0; Tue, 20 Jul 2021 21:08:35 +0200 (CEST) Date: Tue, 20 Jul 2021 21:08:35 +0200 From: Mark Wielaard To: Noah Sanci Cc: elfutils-devel@sourceware.org Subject: Re: [Bug debuginfod/28034] %-escape url characters Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="J1Bnhc+ogcuXVdNR" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 19:08:38 -0000 --J1Bnhc+ogcuXVdNR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Noah, On Tue, Jul 20, 2021 at 07:50:11PM +0200, Mark Wielaard wrote: > > + * run-debuginfod-find.sh: Added a test case ensuring files with % > > + escapable characters in their paths are accessible. > > There are also a couple of changes (fixes?) to the testcases. > Could those be split out? I think you almost had the right fix for a race in killing the last debuginfod server. Does the attached work for you? Thanks, Mark --J1Bnhc+ogcuXVdNR Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-tests-wait-for-PID4-before-setting-to-zero.patch" >From 83b7eb24a5796a4aecc5d32eb0c3f459788c4690 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Tue, 20 Jul 2021 20:50:48 +0200 Subject: [PATCH] tests: wait for PID4 before setting to zero A debuginfod server might take a while to shut down to clean and close the sqlite databases. Wait for the process after killing it and clearing the PID variable so it won't be killed again. Reported-by: Noah Sanci Signed-off-by: Mark Wielaard --- tests/ChangeLog | 4 ++++ tests/run-debuginfod-find.sh | 2 ++ 2 files changed, 6 insertions(+) diff --git a/tests/ChangeLog b/tests/ChangeLog index 1196d6b2..b0303e00 100644 --- a/tests/ChangeLog +++ b/tests/ChangeLog @@ -1,3 +1,7 @@ +2021-07-20 Mark Wielaard + + * tests/run-debuginfod-find.sh: wait for PID4 before setting to zero. + 2021-06-28 Noah Sanci PR25978 diff --git a/tests/run-debuginfod-find.sh b/tests/run-debuginfod-find.sh index 1d664be9..23eac329 100755 --- a/tests/run-debuginfod-find.sh +++ b/tests/run-debuginfod-find.sh @@ -754,6 +754,8 @@ wait_ready $PORT3 'groom{statistic="files scanned (#)"}' 0 wait_ready $PORT3 'groom{statistic="files scanned (mb)"}' 0 kill $PID4 +wait $PID4 +PID4=0 ######################################################################## # set up tests for retrying failed queries. -- 2.32.0 --J1Bnhc+ogcuXVdNR--