public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Adrian Ratiu <adrian.ratiu@collabora.com>
Cc: elfutils-devel@sourceware.org, manojgupta@chromium.org
Subject: Re: [PATCH] configure.ac: drop unnecessary gnu99 extension checks
Date: Mon, 23 Aug 2021 22:21:49 +0200	[thread overview]
Message-ID: <YSQDXelc/6XdVn8T@wildebeest.org> (raw)
In-Reply-To: <20210810125651.3075622-1-adrian.ratiu@collabora.com>

Hi Adrian,

On Tue, Aug 10, 2021 at 03:56:51PM +0300, Adrian Ratiu via Elfutils-devel wrote:
> So in the interest of enabling Clang builds we remove the only
> remaining blocker: the configure checks for nested functions and
> variable length arrays which are also unused.

Can we just remove the whole configure test? And change the AC_PROG_CC
to AC_PROG_CC_C99?

The patch doesn't update the comments about what is being tested, and
the only thing being tested now is Mixed Declarations and Code, which
is a standard part of C99.

Have you tried running make check with an alternative compiler? There
are a couple of "self tests" which run the code on the just produced
binaries and it would be interesting to know whether or not all tests
pass.

Thanks,

Mark

  reply	other threads:[~2021-08-23 20:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 12:56 Adrian Ratiu
2021-08-23 20:21 ` Mark Wielaard [this message]
2021-08-26 12:00   ` Adrian Ratiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSQDXelc/6XdVn8T@wildebeest.org \
    --to=mark@klomp.org \
    --cc=adrian.ratiu@collabora.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=manojgupta@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).