From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 5A3803858D34 for ; Sun, 12 Sep 2021 19:43:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A3803858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x0b.wildebeest.org [172.31.17.141]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 73E4530006CF for ; Sun, 12 Sep 2021 21:43:32 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id DC1972E806E8; Sun, 12 Sep 2021 21:43:31 +0200 (CEST) Date: Sun, 12 Sep 2021 21:43:31 +0200 From: Mark Wielaard To: elfutils-devel@sourceware.org Subject: Re: [PATCH] libdw: set address size, offset size and version on fake CUs Message-ID: References: <20210908201402.38174-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210908201402.38174-1-mark@klomp.org> X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2021 19:43:36 -0000 Hi, On Wed, Sep 08, 2021 at 10:14:02PM +0200, Mark Wielaard wrote: > There are three "fake CUs" that are associated with .debug_loc, > .debug_loclist and .debug_addr. These fake CUs are used for "fake > attributes" to provide values that are stored in these sections > instead of in the .debug_info section. These fake CUs didn't have the > address size, offset size and DWARF version set. This meant that > values that depended on those properties might not be interpreted > correctly. One example was the value associated with a DW_OP_addrx > (which comes from the .debug_addr section). > > Add a testcase using varlocs to test that addresses can correctly be > retrieved for gcc/clang, DWARF4/5 and 32/64 bits objects. > > https://sourceware.org/bugzilla/show_bug.cgi?id=28220 Added ChangeLog entries and pushed. Cheers, Mark