From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id BE95B38618AF for ; Wed, 8 Sep 2021 22:10:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE95B38618AF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x11.wildebeest.org [172.31.17.147]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id C580B300BC88; Thu, 9 Sep 2021 00:10:18 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 896FC2E82169; Thu, 9 Sep 2021 00:10:18 +0200 (CEST) Date: Thu, 9 Sep 2021 00:10:18 +0200 From: Mark Wielaard To: "Dmitry V. Levin" Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Remove redundant casts of memory allocating functions returning void * Message-ID: References: <20210906080000.GA12297@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210906080000.GA12297@altlinux.org> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 22:10:20 -0000 Hi Dmitry, On Mon, Sep 06, 2021 at 08:00:00AM +0000, Dmitry V. Levin wrote: > Return values of functions returning "void *", e.g. calloc, malloc, > realloc, xcalloc, xmalloc, and xrealloc, do not need explicit casts. This does make the code slightly more readable. And the cast doesn't really add much useful info. So please apply. Thanks, Mark