From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id DB98F3857817
 for <elfutils-devel@sourceware.org>; Wed,  8 Sep 2021 22:19:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB98F3857817
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from reform (deer0x11.wildebeest.org [172.31.17.147])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id CF809300BC88;
 Thu,  9 Sep 2021 00:19:13 +0200 (CEST)
Received: by reform (Postfix, from userid 1000)
 id 991372E83138; Thu,  9 Sep 2021 00:19:13 +0200 (CEST)
Date: Thu, 9 Sep 2021 00:19:13 +0200
From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 2/2] Use xasprintf instead of asprintf followed by
 error(EXIT_FAILURE)
Message-ID: <YTk24ZYFygV1/xI6@wildebeest.org>
References: <20210906100000.GA13778@altlinux.org>
 <20210906100000.GB13778@altlinux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210906100000.GB13778@altlinux.org>
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Sep 2021 22:19:17 -0000

Hi Dmitry,

On Mon, Sep 06, 2021 at 10:00:00AM +0000, Dmitry V. Levin wrote:
> +	* color.c (parse_opt): Replace asprintf followed by error(EXIT_FAILURE)
> +	with xasprintf.

> +	* objdump.c (show_disasm): Replace asprintf followed by
> +	error(EXIT_FAILURE) with xasprintf.
> +	* readelf.c (handle_gnu_hash): Likewise.
> +	* unstrip.c (handle_output_dir_module, main): Likewise.

All these replacements look correct. Please apply.

Thanks,

Mark