From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id E4AE03858420 for ; Fri, 17 Sep 2021 17:49:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E4AE03858420 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x02.wildebeest.org [172.31.17.132]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 8A76E3000648; Fri, 17 Sep 2021 19:49:16 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 2E9002E804F0; Fri, 17 Sep 2021 19:49:00 +0200 (CEST) Date: Fri, 17 Sep 2021 19:49:00 +0200 From: Mark Wielaard To: Noah Sanci Cc: elfutils-devel@sourceware.org Subject: Re: debuginfod: Query debuginfod servers before printing response Message-ID: References: <49932c2202b51969a8ee36648494eb0fa9e73dee.camel@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Sep 2021 17:49:19 -0000 Hi Noah, On Fri, Sep 17, 2021 at 01:38:50PM -0400, Noah Sanci via Elfutils-devel wrote: > Here is an updated patch, removing checks for http response headers > which debuginfod is not guaranteed > to respond with. These headers caused tests to fail despite receiving > sufficient headers to confirm functionality. Yes, this looks good. Just checking for Content-Length and the new X-DEBUGINFOD- headers should be good enough. Nice commit message. Please push. Thanks, Mark