From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH v2] Improve building with LTO
Date: Tue, 9 Nov 2021 00:18:31 +0100 [thread overview]
Message-ID: <YYmwR57eKHPs9cU8@wildebeest.org> (raw)
In-Reply-To: <20211108100228.GC27916@altlinux.org>
Hi Dmitry,
On Mon, Nov 08, 2021 at 01:02:28PM +0300, Dmitry V. Levin wrote:
> > Thanks. This patch was indeed one reason I kept postponing the release,
> > because I didn't have have time to properly review it.
> >
> > Which gcc versions have you tried this against (with/without -flto?)
>
> I tested with gcc10 and gcc11.
> I could try older versions, although I didn't feel that necessary.
I also did try with gcc 4.8 and gcc 8 (both without lto though).
> https://sourceware.org/bugzilla/show_bug.cgi?id=27367 will likely strike
> those who would build elfutils with -flto using gcc11+.
But only if they use -ffat-lto-objects (which isn't the default)? Did
you see and try the patch I proposed? Do you think we should include
it? I would like someone else to check/try it.
> > does also impact symbol versioning for non-lto builds, so I am still a
> > little hesitant. I'll try to do some tests to make sure things look ok
> > with different gcc versions.
>
> What do you mean by "it does also impact symbol versioning for non-lto
> builds"? The code for non-lto builds changes, but the versioning
> should remain the same, shouldn't it?
I meant I am paranoid :) We are using slightly different asm or an
attribute to mark the symbol version than we did before. But I double
checked the exported versioned symbols with and without this patch on
different gcc versions and they look fine.
So I did just now push this patch.
Cheers,
Mark
next prev parent reply other threads:[~2021-11-08 23:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 22:57 [PATCH] " Alexander Miller
2021-02-17 20:22 ` Mark Wielaard
2021-02-18 14:27 ` Alexander Miller
2021-02-18 2:38 ` [PATCH v2] " Alexander Miller
2021-08-28 9:31 ` Dmitry V. Levin
2021-11-04 11:23 ` Dmitry V. Levin
2021-11-04 12:12 ` Mark Wielaard
2021-11-08 10:02 ` Dmitry V. Levin
2021-11-08 23:18 ` Mark Wielaard [this message]
2021-11-09 8:58 ` Dmitry V. Levin
2021-11-09 9:04 ` Martin Liška
2021-11-09 9:09 ` Dmitry V. Levin
2021-11-09 9:11 ` Martin Liška
2021-11-09 11:45 ` Mark Wielaard
2021-11-09 13:31 ` Martin Liška
2021-11-09 13:33 ` Martin Liška
2021-11-09 17:49 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYmwR57eKHPs9cU8@wildebeest.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ldv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).