From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
 by sourceware.org (Postfix) with ESMTPS id 099083858411
 for <elfutils-devel@sourceware.org>; Thu, 11 Nov 2021 08:20:21 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 099083858411
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from reform (deer0x16.wildebeest.org [172.31.17.152])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 9E4B6302FBAB;
 Thu, 11 Nov 2021 09:20:18 +0100 (CET)
Received: by reform (Postfix, from userid 1000)
 id B3CAB2E8070C; Thu, 11 Nov 2021 09:20:18 +0100 (CET)
Date: Thu, 11 Nov 2021 09:20:18 +0100
From: Mark Wielaard <mark@klomp.org>
To: =?iso-8859-1?Q?=C9rico?= Nogueira <ericonr@disroot.org>
Cc: elfutils-devel@sourceware.org,
 =?iso-8859-1?Q?=C9rico?= Nogueira <erico.erc@gmail.com>
Subject: Re: [PATCH] debuginfod: fix compilation on platforms without <error.h>
Message-ID: <YYzSQqPnRh8orV1g@wildebeest.org>
References: <20211111001748.4977-1-ericonr@disroot.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211111001748.4977-1-ericonr@disroot.org>
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Nov 2021 08:20:22 -0000

Hi Érico,

On Wed, Nov 10, 2021 at 09:17:48PM -0300, Érico Nogueira via Elfutils-devel wrote:
> "system.h" only declares the error() function, so it needs to be in an
> 'extern "C"' block, otherwise linking fails.
> 
> Since we are here, use quotes for "system.h" header, since it's a local
> header, not a system one.

Thanks, applied.

Cheers,

Mark