From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Subject: Re: [PATCH] tests: varlocs workaround format-overflow errors
Date: Thu, 9 Dec 2021 00:17:16 +0100 [thread overview]
Message-ID: <YbE8/MwGPbHfKfTf@wildebeest.org> (raw)
In-Reply-To: <20211204212729.276818-1-mark@klomp.org>
On Sat, Dec 04, 2021 at 10:27:29PM +0100, Mark Wielaard wrote:
> In function ‘printf’,
> inlined from ‘handle_attr’ at varlocs.c:932:3:
> error: ‘%s’ directive argument is null [-Werror=format-overflow=]
>
> The warning is technically correct. A %s argument should not be
> NULL. Although in practice all implementations will print it as
> "(null)". Workaround this by simply changing the dwarf string
> functions to return an "<unknown>" string. The test is for the correct
> names, either "(null)" or "<unknown>" would make it fail (also remove
> a now unnecessary assert, the switch statement will check for unknown
> opcodes anyway).
Pushed,
Mark
prev parent reply other threads:[~2021-12-08 23:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 21:27 Mark Wielaard
2021-12-08 23:17 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbE8/MwGPbHfKfTf@wildebeest.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).