public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Evgeny Vereshchagin <evvers@ya.ru>
Cc: david korczynski <david@adalogics.com>, elfutils-devel@sourceware.org
Subject: Re: Some fuzzer workarounds
Date: Wed, 23 Mar 2022 10:21:50 +0100	[thread overview]
Message-ID: <YjrmrpJM2Vo6iZDT@wildebeest.org> (raw)
In-Reply-To: <63B325E4-E8F8-4524-A53B-6AEFEA1A4513@ya.ru>

Hi Evgeny,

On Wed, Mar 23, 2022 at 04:15:42AM +0300, Evgeny Vereshchagin wrote:
> > I think that is a good idea. I really believe all the issues reported
> > by MSAN are bogus.
> 
> They are but all those issues should be gone once
> https://github.com/google/oss-fuzz/pull/7422 and
> https://github.com/google/oss-fuzz/pull/7401 are merged. I ran the
> fuzzers with those patches applied for a few hours and MSan didn't
> complain. I'll flip the flag there a bit later today anyway and
> maybe bring it back in a month or so if it isn't noisy.

That makes sense. You do indeed have to "rebuild the world" for MSAN
to work. I am slightly surprised it doesn't work with
-D_FORTIFY_SOURCE (which we indeed try to enable by default).

> > While the UBSAN and ASAN issues seem reasonable. At least I have a fix
> > for the last one (45952 Misaligned-address in elf_cvt_gnuhash):
> > https://sourceware.org/pipermail/elfutils-devel/2022q1/004782.html
> > https://code.wildebeest.org/git/user/mjw/elfutils/commit/?h=fuzz
> 
> I rebased it on top my "fuzzing" branch and the fuzzers, static analyzers, the unit tests
> on various architectures and so on confirmed that the issue is gone. Thanks!

Thanks for testing. Pushed.

Cheers,

Mark


  reply	other threads:[~2022-03-23  9:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 13:30 Mark Wielaard
2022-03-17 13:30 ` [PATCH 1/2] libelf: Take map offset into account for Shdr alignment check in elf_begin Mark Wielaard
2022-03-17 13:30 ` [PATCH 2/2] libelf: Make sure ar_size starts with a digit before calling atol Mark Wielaard
2022-03-18  9:11   ` Evgeny Vereshchagin
2022-03-18 11:44     ` Mark Wielaard
2022-03-18 13:18       ` Evgeny Vereshchagin
2022-03-18  7:26 ` Some fuzzer workarounds Evgeny Vereshchagin
2022-03-19 11:08   ` Evgeny Vereshchagin
2022-03-21  2:24   ` Evgeny Vereshchagin
2022-03-21 10:50   ` Mark Wielaard
2022-03-21 11:10     ` Evgeny Vereshchagin
2022-03-21 14:33       ` Evgeny Vereshchagin
2022-03-21 17:30         ` Mark Wielaard
2022-03-21 18:01           ` Evgeny Vereshchagin
2022-03-22 16:59       ` Evgeny Vereshchagin
2022-03-23  0:35         ` Mark Wielaard
2022-03-23  1:15           ` Evgeny Vereshchagin
2022-03-23  9:21             ` Mark Wielaard [this message]
2022-03-21 10:57 ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjrmrpJM2Vo6iZDT@wildebeest.org \
    --to=mark@klomp.org \
    --cc=david@adalogics.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=evvers@ya.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).