From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
 by sourceware.org (Postfix) with ESMTPS id 1E9B83858D33
 for <elfutils-devel@sourceware.org>; Sun, 24 Apr 2022 15:04:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E9B83858D33
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from reform (deer0x0b.wildebeest.org [172.31.17.141])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id A7E94302BBED;
 Sun, 24 Apr 2022 17:04:50 +0200 (CEST)
Received: by reform (Postfix, from userid 1000)
 id BA7552E804F0; Sun, 24 Apr 2022 17:04:49 +0200 (CEST)
Date: Sun, 24 Apr 2022 17:04:49 +0200
From: Mark Wielaard <mark@klomp.org>
To: Aaron Merey <amerey@redhat.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] debuginfod: Use the debuginfod-size response header
Message-ID: <YmVnEYj+ElBjuDej@wildebeest.org>
References: <CAJDtP-TPGr0Du+M8yQdtGfzv6hi4HXmwD0AjSVNmdnrcwh8P4w@mail.gmail.com>
 <20220422225641.317366-1-amerey@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220422225641.317366-1-amerey@redhat.com>
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Apr 2022 15:04:55 -0000

Hi Aaron,

On Fri, Apr 22, 2022 at 06:56:41PM -0400, Aaron Merey via Elfutils-devel wrote:
> I've updated the patch below with the changes Mark recommended.
> 
> A couple X-DEBUGINFOD-SIZE tests were added in another patch I recently
> posted [1] that also fixes a bug when computing this header's value for
> an archived file.
> 
> Aaron 
> 
> [1] https://sourceware.org/pipermail/elfutils-devel/2022q2/004936.html
> 
> From b56f1568b832fe1c23ffb711aa0486fbd2c5067f Mon Sep 17 00:00:00 2001
> From: Aaron Merey <amerey@redhat.com>
> Date: Tue, 11 Jan 2022 22:07:55 -0500
> 
> debuginfod: Use the debuginfod-size response header
> 
> In some cases the content-length header may not be available in order
> to pass to a progressfn.  If content-length isn't available then attempt
> to get the size of the download from the debuginfod-size header instead.
> 
> It should be mentioned that if a compressed file (ex. gzip) is being
> transferred, the actual transfer length will be less than debuginfod-size.
> In this case debuginfod-size is a best-guess upper bound on the size of
> the transfer.

Looks good. Pleas commit.

Cheers,

Mark