public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Subject: Re: ☺ Buildbot (GNU Toolchain): elfutils - build successful (master)
Date: Mon, 1 Aug 2022 12:22:23 +0200	[thread overview]
Message-ID: <YuepX6WtLJm6l1mm@wildebeest.org> (raw)
In-Reply-To: <20220801093633.1969A3858CDA@sourceware.org>

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

On Mon, Aug 01, 2022 at 09:36:33AM +0000, builder--- via Elfutils-devel wrote:
> A restored build has been detected on builder elfutils-fedora-s390x while building elfutils.
> 
> Full details are available at:
>     https://builder.sourceware.org/buildbot/#builders/43/builds/48
> 
> Build state: build successful
> Revision: d0ff4e224738adf34eba38dc33ffda67e5da6634
> Worker: fedora-s390x
> Build Reason: (unknown)
> Blamelist: Di Chen <dichen@redhat.com>, Mark Wielaard <mark@klomp.org>

That is good! \o/

> A new failure has been detected on builder elfutils-opensusetw-x86_64 while building elfutils.
> 
> Full details are available at:
>     https://builder.sourceware.org/buildbot/#builders/88/builds/17
> 
> Build state: failed test (failure)
> Revision: d0ff4e224738adf34eba38dc33ffda67e5da6634
> Worker: bb3
> Build Reason: (unknown)
> Blamelist: Mark Wielaard <mark@klomp.org>

But that is bad :{

> - 8: make distcheck ( failure )
>     Logs:
>         - stdio: https://builder.sourceware.org/buildbot/#builders/88/builds/17/steps/8/logs/stdio
>         - test-suite.log: https://builder.sourceware.org/buildbot/#builders/88/builds/17/steps/8/logs/test-suite_log
>         - warnings (3): https://builder.sourceware.org/buildbot/#builders/88/builds/17/steps/8/logs/warnings__3_

The issue is in run-debuginfod-percent-escape.sh.

It does a kill -USR1 $PID1 and then wait_ready $PORT1
'thread_work_total{role="traverse"}' 1

But that can race with the initial traversal done at startup.

Fixed as attached.

Cheers,

Mark

[-- Attachment #2: 0001-tests-Add-initial-scan-wait_ready-in-run-debuginfod-.patch --]
[-- Type: text/x-diff, Size: 2117 bytes --]

From bcd7651eb06f2e57a04ca97ae69b42c174fe3db3 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Mon, 1 Aug 2022 12:18:30 +0200
Subject: [PATCH] tests: Add initial scan wait_ready in
 run-debuginfod-percent-escape.sh

Otherwise wait_ready for thread_work_total{role="traverse"} after the
kill -USR1 can be either zero, one or two. We want to see it change to
one first, then after the kill -USR1 it should change to two to be sure
the scan happened after the new binary was created.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 tests/ChangeLog                        | 4 ++++
 tests/run-debuginfod-percent-escape.sh | 5 +++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/tests/ChangeLog b/tests/ChangeLog
index fb573d80..0c6f68ef 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,7 @@
+2022-08-01  Mark Wielaard  <mark@klomp.org>
+
+	* run-debuginfod-percent-escape.sh: Add initial scan wait_ready.
+
 2022-04-28  Di Chen  <dichen@redhat.com>
 
 	* run-readelf-Dd.sh: New test.
diff --git a/tests/run-debuginfod-percent-escape.sh b/tests/run-debuginfod-percent-escape.sh
index f7d8dc66..cd867427 100755
--- a/tests/run-debuginfod-percent-escape.sh
+++ b/tests/run-debuginfod-percent-escape.sh
@@ -34,7 +34,8 @@ tempfiles vlog$PORT1
 errfiles vlog$PORT1
 # Server must become ready
 wait_ready $PORT1 'ready' 1
-# Be patient when run on a busy machine things might take a bit.
+# And initial scan should be done
+wait_ready $PORT1 'thread_work_total{role="traverse"}' 1
 
 # Build a non-stripped binary
 echo "int main() { return 0; }" > ${PWD}/F/p++r\$\#o^^g.c
@@ -44,7 +45,7 @@ BUILDID=`env LD_LIBRARY_PATH=$ldpath ${abs_builddir}/../src/readelf \
 tempfiles ${PWD}/F/p++r\$\#o^^g.c ${PWD}/F/p++r\$\#o^^g
 kill -USR1 $PID1
 # Now there should be 1 files in the index
-wait_ready $PORT1 'thread_work_total{role="traverse"}' 1
+wait_ready $PORT1 'thread_work_total{role="traverse"}' 2
 wait_ready $PORT1 'thread_work_pending{role="scan"}' 0
 wait_ready $PORT1 'thread_busy{role="scan"}' 0
 rm -rf $DEBUGINFOD_CACHE_PATH # clean it from previous tests
-- 
2.30.2


  reply	other threads:[~2022-08-01 10:22 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01  9:36 builder
2022-08-01 10:22 ` Mark Wielaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-12-21 19:24 builder
2022-12-20 18:26 builder
2022-12-13 17:11 builder
2022-12-12 20:57 builder
2022-11-29 10:00 builder
2022-11-21 17:48 builder
2022-11-07 17:55 builder
2022-11-03 15:44 builder
2022-11-03 14:45 builder
2022-11-02 17:32 builder
2022-11-02  0:22 builder
2022-11-01 23:03 builder
2022-10-27 19:50 builder
2022-10-27 14:11 builder
2022-10-16 21:18 builder
2022-10-16 16:58 builder
2022-09-27 16:07 builder
2022-08-07 23:42 builder
2022-08-03 15:18 builder
2022-08-01 10:40 builder
2022-07-29 18:47 builder
2022-07-13 19:05 builder
2022-07-13 19:04 builder
2022-07-13 19:03 builder
2022-07-13 19:00 builder
2022-07-13 18:56 builder
2022-07-13 18:55 builder
2022-07-13 18:53 builder
2022-07-13 18:53 builder
2022-07-13 18:51 builder
2022-07-13 18:50 builder
2022-07-13 18:50 builder
2022-07-13 18:47 builder
2022-07-10 22:52 builder
2022-06-02 17:31 builder
2022-05-27 22:40 builder
2022-05-14 22:37 builder
2022-05-14 15:08 builder
2022-05-10  1:10 builder
2022-05-03  0:25 builder
2022-05-03 15:02 ` Mark Wielaard
2022-04-24 11:05 builder
2022-04-23  1:22 builder
2022-04-19 14:05 builder
2022-04-19 10:20 builder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuepX6WtLJm6l1mm@wildebeest.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).