From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) by sourceware.org (Postfix) with ESMTPS id 957233858D1E for ; Tue, 7 Nov 2023 17:13:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 957233858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=osandov.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=osandov.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 957233858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699377215; cv=none; b=bIe+iaUQ+Hg8m1XXTTr2EfvZd7xHKy7Aes62hYHRbbHNo3N8o58CcpGzBqN4OPhfNAsOczc0IqAZqFjxHPHhWMbrpHIdzyWBwaTGnMk1ZBb5E7lGKSZ4oK+HEpaV6Syal6SjynjsaQQofqxZmE6YO6fyLLQhlq6XVtrz/qwH7ms= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699377215; c=relaxed/simple; bh=FZ/dcLMOTQgGBQh8FzA7oCEblh5eLd0EalrngkujH58=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=qHu+Nk4ZbsgBQJF47J92WyCrHnFNmSM6sPrGrB2disn3xx77sqLUss0pfvGUA4cjKhsmXR8qy1hR44Y3j8iDjtZuDY+QClCpdiwq6yuFEcTt+8LnO+dfYxXaG7K6N/UwLBuVTey1b2m0jEGSSUWMOzG/j2fS2kI5hOJJzEXKrCs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-5875c300becso3391393eaf.0 for ; Tue, 07 Nov 2023 09:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20230601.gappssmtp.com; s=20230601; t=1699377214; x=1699982014; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gW2Ogj3mw6aiqw2+2iMMjCK2mQDJQXmliY5slMgJZgI=; b=HoqlcPRMuEoC0myOaNHwHFXSyIDntNczm5Y0ALFL3Jit7Aq0yaGczschUw75/hK7J+ nKj/MtyrROA8uCGUYBHLn3Yx0GVMTCh+UhrtuHR/BfWlLOTk4pPD6TPrSNm0BGVHJxZG /YtZ+gS+JT2hbnRZmPS5+GOqbkxUOQqlBtKwlq6ecr3pGfQ3/mwyfv3tji1Ziz51vv0W pgpx4zE3d4Uf9SBtbZRo3rXionhcCIB7SIIsgwIt5Kr36jbWxewIKVtF8tZUjVXtqqOx uSiW3zwuQ4nIxUWqonbii/426GOA6vsqaDFAz2q88cedTUUwRlbMX5QDtsy2dfYGC8hs JC3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699377214; x=1699982014; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gW2Ogj3mw6aiqw2+2iMMjCK2mQDJQXmliY5slMgJZgI=; b=WFa/Paovbbunxcp9i/wyjVjnW0qf2H5VKTGkQV1wWSMjUO9afQmkbm/MtSAmE7SF/n ae1LHOv8E9K3hXqKIjiVneSBhmIBnpaVIGQ9ke/aEtQUBcGCaCUC1u+qzYewGDTIq9MD 6i/vYmSJzB1mKwWoxSwmm25naSWQaj/jIt/VltZ0zj6YIUkughCAdovq7TemMpE6Srrb RAvOl90njGNW2dGCugnylC8GM+2dKWYLmCoR5bMovUXOvvzC6BmNTeK1cJc4pwlbXRDX smgcAQ5YEdnLIY8uTJQfg54M2ZUJFetQ+YoI5bXOPcJcsRBaxZZPVy3ha+/jNkVUHWOV vVzQ== X-Gm-Message-State: AOJu0Yw5dd5xIZyU8d0baS0niMkZo6q02avVwZJI1STtBVpEdFoi9L1T +nKJGjIPNGg+Liu/pYuCEGSbPa66WruK3RSrt6U= X-Google-Smtp-Source: AGHT+IGfKfbS559ckdxIpjJ/vB0kd0XqxQ53nErJrjSZYrFYU93oeR+Q0oBkp3lgjq/qMtP+ivhx/Q== X-Received: by 2002:a05:6358:5924:b0:168:e7ab:6877 with SMTP id g36-20020a056358592400b00168e7ab6877mr32352192rwf.6.1699377213826; Tue, 07 Nov 2023 09:13:33 -0800 (PST) Received: from telecaster ([2620:10d:c090:400::4:fc06]) by smtp.gmail.com with ESMTPSA id x184-20020a6363c1000000b0059ce3d1def5sm1677125pgb.45.2023.11.07.09.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 09:13:33 -0800 (PST) Date: Tue, 7 Nov 2023 09:13:32 -0800 From: Omar Sandoval To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH 00/14] elfutils: DWARF package (.dwp) file support Message-ID: References: <20231102230557.GS8429@gnu.wildebeest.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231102230557.GS8429@gnu.wildebeest.org> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Nov 03, 2023 at 12:05:57AM +0100, Mark Wielaard wrote: > Hi Omar, > > On Wed, Sep 27, 2023 at 11:20:49AM -0700, Omar Sandoval wrote: > > This patch series adds support for DWARF package files to libdw and the > > elfutils tools. It supports the GNU DebugFission format for DWARF 4 [1] > > and the format standardized in DWARF 5 (section 7.3.5 "DWARF Package > > Files"). It supports both automatically opening the .dwp file for a > > skeleton unit and examining the .dwp file alone, just like for .dwo > > files. > > I had hoped to review and apply all this for the 0.190 release > tomorrow, but wasn't fast enough. No problem, I'll be happy to see it in 0.191 instead. > In general it looks very good and > most has been applied as is. Except for the last patch I don't have > real concerns, just a few questions (see the specific reviews). > > > Patch 1 is a trivial cleanup I found while developing this. Patches 2-6 > > are fixes for unrelated bugs in split DWARF and/or DWARF 5 that I > > encountered while adding test cases for this series. > > These have all been applied some time ago. > > > The actual dwp support is in patches 7-10 and 13, including test cases. > > 7 and 9 have been applied already. 8 has some comments/nitpicks, I can > probably easily be convinced to accept it. 10 looks good, but depends > on 8, some questions, specificly about handling split type units. 13 > looks good, but depends on 8 and 10. I replied to patch 8 with how drgn wants to use the new interface. I also replied with a couple of questions about how you'd like me to split up patch 8 and handle errors in a couple of the existing codepaths. > > Patches 11 and 12 enable testing macro information in dwp files. > > Both applied. > > > Patch 14 adds support and tests for an LLVM extension to the dwp > > format. > > I have to think a bit more on this. Yeah, the whole situation is very unfortunate. I tried to keep the workaround as unintrusive as possible, so it wouldn't be the end of the world if we had to carry our own patch for it. Of course, since LLVM supports it upstream, I'd definitely prefer for elfutils to support it upstream, too. I'll rebase my remaining patches and address the comments so far while I wait for your responses. Thanks!