From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s01.bc.larksuite.com (s01.bc.larksuite.com [209.127.230.19]) by sourceware.org (Postfix) with UTF8SMTPS id 9E0D43858C5F for ; Thu, 18 May 2023 06:14:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E0D43858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=oss-cipunited-com.20200927.dkim.feishu.cn; t=1684390457; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=KHASv+d8Ik7oLgEsnT7jOo6NC/uXLUQEAXxq1xtu3Qw=; b=QIUCIcObsHh/f0Wla17gbsXQSdFpn/XE6a6Rc9vA92pRZeua/ky+zBG8zwG2xACR7MX5b4 OxnoYYxyot4y4Tb5k4k2zYAm6irwaTkkPsaBdkwhz8s2XSao+n2UNYfsNmHriS6fkXIidT qi0wA6UMn+XuDHFQ9rYH+HSTd3kveRLccglZRg2TmkIyo3npxfRhJz2o3jd4nl0Jat+Luc IDC4IbOD7YWkNCRXcSzWNaFioS3j6hcSQdGytHj8ETnXcXTwNOTQhqYRMz15s8FrPyDAWV I/EoSJjBBC8voIdlBjAAfiI+aXHO2IcKQZrAFu6IMSWtj435CnNOkTaFvmQH4w== From: "Ying Huang" Content-Language: en-US References: <20230411081141.1762395-1-ying.huang@oss.cipunited.com> <20230411081141.1762395-5-ying.huang@oss.cipunited.com> Date: Thu, 18 May 2023 14:14:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Transfer-Encoding: 8bit Content-Type: multipart/alternative; boundary=25707e2fa6befde97e74397a49b64d02500b4c09a180529b9c4f6a590b5c Mime-Version: 1.0 In-Reply-To: X-Lms-Return-Path: To: "Mark Wielaard" , Cc: Subject: Re: [PATCH 4/5] stack: Fix stack unwind failure on mips Message-Id: X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HTML_MESSAGE,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --25707e2fa6befde97e74397a49b64d02500b4c09a180529b9c4f6a590b5c Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi, =E5=9C=A8 2023/5/12 00:07, Mark Wielaard =E5=86=99=E9=81=93: >> libebl_backends_a_SOURCES =3D $(i386_SRCS) $(sh_SRCS) $(x86_64_SRCS) \ >> $(ia64_SRCS) $(alpha_SRCS) $(arm_SRCS) \ >> diff --git a/backends/mips_cfi.c b/backends/mips_cfi.c >> new file mode 100644 >> index 00000000..77132cc1 >> --- /dev/null >> +++ b/backends/mips_cfi.c >> @@ -0,0 +1,68 @@ >> +/* MIPS ABI-specified defaults for DWARF CFI. >> + Copyright (C) 2009 Red Hat, Inc. >> + Copyright (C) 2023 CIP United Inc. >> + This file is part of elfutils. >> + >> + This file is free software; you can redistribute it and/or modify >> + it under the terms of either >> + >> + * the GNU Lesser General Public License as published by the Free >> + Software Foundation; either version 3 of the License, or (at >> + your option) any later version >> + >> + or >> + >> + * the GNU General Public License as published by the Free >> + Software Foundation; either version 2 of the License, or (at >> + your option) any later version >> + >> + or both in parallel, as here. >> + >> + elfutils is distributed in the hope that it will be useful, but >> + WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + General Public License for more details. >> + >> + You should have received copies of the GNU General Public License and >> + the GNU Lesser General Public License along with this program. If >> + not, see . */ >> + >> +#ifdef HAVE_CONFIG_H >> +# include >> +#endif >> + >> +#include >> + >> +#define BACKEND mips_ >> +#include "libebl_CPU.h" >> + >> +int >> +mips_abi_cfi (Ebl *ebl __attribute__ ((unused)), Dwarf_CIE *abi_info) >> +{ >> + static const uint8_t abi_cfi[] =3D >> + { >> + DW_CFA_def_cfa, ULEB128_7 (31), ULEB128_7 (0), >> + /* Callee-saved regs. */ >> + DW_CFA_same_value, ULEB128_7 (16), /* s0 */ >> + DW_CFA_same_value, ULEB128_7 (17), /* s1 */ >> + DW_CFA_same_value, ULEB128_7 (18), /* s2 */ >> + DW_CFA_same_value, ULEB128_7 (19), /* s3 */ >> + DW_CFA_same_value, ULEB128_7 (20), /* s4 */ >> + DW_CFA_same_value, ULEB128_7 (21), /* s5 */ >> + DW_CFA_same_value, ULEB128_7 (22), /* s6 */ >> + DW_CFA_same_value, ULEB128_7 (23), /* s7 */ >> + DW_CFA_same_value, ULEB128_7 (28), /* gp */ >> + DW_CFA_same_value, ULEB128_7 (29), /* sp */ >> + DW_CFA_same_value, ULEB128_7 (30), /* fp */ >> + >> + DW_CFA_val_offset, ULEB128_7 (29), ULEB128_7 (0), >> + }; >> + >> + abi_info->initial_instructions =3D abi_cfi; >> + abi_info->initial_instructions_end =3D &abi_cfi[sizeof abi_cfi]; >> + abi_info->data_alignment_factor =3D -4; >> + >> + abi_info->return_address_register =3D 31; /* %ra */ >> + >> + return 0; >> +} > Looks good, but do you have a reference to the ABI docs would be nice > to add an URL as comment for people to double check. =C2=A0=C2=A0=C2=A0 document: =C2=A0=C2=A0=C2=A0 https://irix7.com/techpubs/007-2816-004.pdf =C2=A0=C2=A0=C2=A0 Page17 Page18 Page14 >> diff --git a/backends/mips_initreg.c b/backends/mips_initreg.c >> new file mode 100644 >> index 00000000..31b8de13 >> --- /dev/null >> +++ b/backends/mips_initreg.c >> @@ -0,0 +1,70 @@ >> +/* Fetch live process registers from TID. >> + Copyright (C) 2023 CIP United Inc. >> + This file is part of elfutils. >> + >> + This file is free software; you can redistribute it and/or modify >> + it under the terms of either >> + >> + * the GNU Lesser General Public License as published by the Free >> + Software Foundation; either version 3 of the License, or (at >> + your option) any later version >> + >> + or >> + >> + * the GNU General Public License as published by the Free >> + Software Foundation; either version 2 of the License, or (at >> + your option) any later version >> + >> + or both in parallel, as here. >> + >> + elfutils is distributed in the hope that it will be useful, but >> + WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + General Public License for more details. >> + >> + You should have received copies of the GNU General Public License and >> + the GNU Lesser General Public License along with this program. If >> + not, see . */ >> + >> +#ifdef HAVE_CONFIG_H >> +# include >> +#endif >> + >> +#include >> +#if (defined(mips) || defined(__mips) || defined(__mips__) || defined(M= IPS) || defined(__MIPS__)) && defined(__linux__) >> +# include >> +# include >> +#endif >> + >> +#define BACKEND mips_ >> +#include "libebl_CPU.h" >> +#include >> + >> + >> +bool >> +mips_set_initial_registers_tid (pid_t tid __attribute__ ((unused)), >> + ebl_tid_registers_t *setfunc __attribute__ ((unused)), >> + void *arg __attribute__ ((unused))) >> +{ >> +#if (!defined(mips) && !defined(__mips) && !defined(__mips__) && !defin= ed(MIPS) && !defined(__MIPS__)) || !defined(__linux__) >> + return false; >> +#else /* __mips__ */ >> +/* For PTRACE_GETREGS */ >> +struct pt_regs { >> + uint64_t regs[32]; >> + uint64_t lo; >> + uint64_t hi; >> + uint64_t pc; >> + uint64_t badvaddr; >> + uint64_t cause; >> + uint64_t status; >> +}; > Isn't this defined in some standard (or glibc/linux specific) header? =C2=A0=C2=A0=C2=A0 OK, I would add +#include =C2=A0=C2=A0=C2=A0 Thanks, =C2=A0=C2=A0=C2=A0 Ying= --25707e2fa6befde97e74397a49b64d02500b4c09a180529b9c4f6a590b5c--