From: Mark Wielaard <mark@klomp.org>
To: "Frank Ch. Eigler" <fche@redhat.com>, elfutils-devel@sourceware.org
Subject: Re: PATCH: testsuite debuginfod
Date: Tue, 05 Oct 2021 18:55:34 +0200 [thread overview]
Message-ID: <a093de76d1281ab3dfb681e3bc13bef8d4583b4e.camel@klomp.org> (raw)
In-Reply-To: <20210930145030.GC11484@redhat.com>
Hi Frank,
On Thu, 2021-09-30 at 10:50 -0400, Frank Ch. Eigler via Elfutils-devel
wrote:
> commit 85602ff68179053f19a2005df4fc653a69757584 (HEAD -> master)
> Author: Frank Ch. Eigler <fche@redhat.com>
> Date: Thu Sep 30 10:48:00 2021 -0400
>
> debuginfod testsuite: Use ! CMD syntax.
>
> Previously, we had a mishmash of iffy && || constructs to
> reverse the rc of a subprocess that we expected to fail.
> Now use
> ! CMD
> or
> ! (CMD | CMD)
> more systematically where possible.
>
> Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Thanks, the && || conditionals do make my head hurt (I am not as
logical as I like). This looks much simpler.
I wish we can use this. But we use -e to make any failing command
(pipeline) fail the script/test. And man bash says (under -e Exit
immediately):
The shell does not exit if the command that fails is part of the
command list immediately following a while or until keyword, part
of the test following the if or elif reserved words, part of any
command executed in a && or || list except the command following
the final && or ||, any command in a pipeline but the last, or if
the command's return value is being inverted with !.
So I am afraid any '! should_fail_but_does_not' will not actually exit
and so doesn't FAIL the test. Could you double check that?
Thanks,
Mark
next prev parent reply other threads:[~2021-10-05 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 14:50 Frank Ch. Eigler
2021-10-05 16:55 ` Mark Wielaard [this message]
2021-12-05 17:30 ` Mark Wielaard
2022-04-15 10:54 ` Mark Wielaard
2022-04-22 19:26 Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a093de76d1281ab3dfb681e3bc13bef8d4583b4e.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).