From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 4C5F03856B5E for ; Mon, 12 Dec 2022 12:58:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C5F03856B5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 256B93045FA6; Mon, 12 Dec 2022 13:58:18 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id B6DEC400142A; Mon, 12 Dec 2022 13:58:17 +0100 (CET) Message-ID: Subject: Re: [PATCH 12/25] libcpu: Use "#define FCT_mod$64r_m FCT_mod$r_m" is enough and can be recognized by clang-cl on windows in i386_data.h From: Mark Wielaard To: Yonggang Luo , elfutils-devel@sourceware.org Date: Mon, 12 Dec 2022 13:58:17 +0100 In-Reply-To: <20221020182603.815-13-luoyonggang@gmail.com> References: <20221020182603.815-1-luoyonggang@gmail.com> <20221020182603.815-13-luoyonggang@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3038.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > libcpu/i386_data.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libcpu/i386_data.h b/libcpu/i386_data.h > index 06356b8a..fe3c4ae1 100644 > --- a/libcpu/i386_data.h > +++ b/libcpu/i386_data.h > @@ -1153,7 +1153,7 @@ FCT_mod$64r_m (struct output_data *d) > return general_mod$r_m (d); > } > #else > -static typeof (FCT_mod$r_m) FCT_mod$64r_m __attribute__ ((alias > ("FCT_mod$r_m"))); > +#define FCT_mod$64r_m FCT_mod$r_m > #endif Thanks, this indeed looks simpler. Added a ChangeLog entry and pushed as: commit dab89fba0e84c948fb270e541d1d1313afd2c2c3 (HEAD -> master) Author: Yonggang Luo Date: Fri Oct 21 02:25:51 2022 +0800 libcpu: Use "#define FCT_mod$64r_m FCT_mod$r_m" in i386_data.h =20 This is enough and can be recognized by clang-cl on windows =20 Signed-off-by: Yonggang Luo Cheers, Mark